You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have verified that this is the correct repository, and the package is maintained by the chocolatey-community user.
I have verified that this is happening in the latest available version of the package.
Chocolatey Version
2.4.2
Chocolatey License
None
Package Version
11.51.0
Current Behaviour
Installation fails because the package does not recognize the correct install path.
The COMMANDER_PATH variable is set to the value "C:\Program Files\Total Commander" before the upgrade.
The installation scripts prints the following message:
TotalCommander installed to 'C:\Program Files\Total Commander '
Setting system environment COMMANDER_PATH
ERROR: Path doesn't exist: C:\Program Files\Total Commander \totalcmd.exe
Please not the trailing blank at the end of the path "C:\Program Files\Total Commander " which should not be there!
Even if I add the parameter --params '/InstallPath="%ProgramFiles%\Total Commander"' (no trailing blank) to the installation it fails with exactly the same message as above. Unsetting the COMMANDER_PATH variable before the installation had the same result. The windows registry does not contain any paths with the trialing blank, so the install script itself seems to be buggy.
Expected Behaviour
It should either use the correct path from the COMMANDER_PATH variable when it exists (without adding a trailing blank) or it should use the /InstallPath parameter correctly.
The packages within this repository are maintained by a small team of volunteer Community Maintainers, in their own time. Their time, like yours is important. Please help them by not wasting it.
This is a community repository where the expectation is that everybody will get involved by raising pull requests to fix problems they find. This will also allow that problem to be fixed more quickly as you don't have to wait for a member of the Community Maintainer Team to pick it up.
If you are unable to fix the issue yourself, the Community Maintainers Team will look at it when time allows. There are no service level agreements, nor should there be any expectation on when people can resolve issues in their own time.
A few dos and don'ts:
Do provide as much information as you can in any issue that you raise.
Don't complain that an issue has not yet been picked up or resolved. You are expected to help out in this community maintained repository. If you are unable to do so, don't complain when others don't adhere to your timelines. There is no SLA nor should you have any expectation of one.
Do read the CONTRIBUTING and COMMITTERS documentation before raising a pull request as it contains valuable information on what automation is used in this repository.
Don't post your frustration in comments. The Community Maintainers Team are not a punching bag for your frustration. You will only end up banned from the repository.
Thank you. (Automatically posted message)
kintrupf
changed the title
(totalcommander) Install fails, path always wrong
(totalcommander) Install fails, adds trailing blank to path
Feb 25, 2025
Looking at the log, this looks like it is the installer of Total Commander that creates the necessary registry key while appending the space (and we take the value as is).
There is still something we can do by trimming the value (possibly test as is before trimming the value though), as such I'll mark this issue as an up for grabs (should be fairly easy to implement).
Checklist
Chocolatey Version
2.4.2
Chocolatey License
None
Package Version
11.51.0
Current Behaviour
Installation fails because the package does not recognize the correct install path.
The COMMANDER_PATH variable is set to the value "C:\Program Files\Total Commander" before the upgrade.
The installation scripts prints the following message:
Please not the trailing blank at the end of the path "C:\Program Files\Total Commander " which should not be there!
Even if I add the parameter
--params '/InstallPath="%ProgramFiles%\Total Commander"'
(no trailing blank) to the installation it fails with exactly the same message as above. Unsetting the COMMANDER_PATH variable before the installation had the same result. The windows registry does not contain any paths with the trialing blank, so the install script itself seems to be buggy.Expected Behaviour
It should either use the correct path from the
COMMANDER_PATH
variable when it exists (without adding a trailing blank) or it should use the/InstallPath
parameter correctly.Steps To Reproduce
choco upgrade totalcommander
Environment
Chocolatey Log
Anything else?
No response
The text was updated successfully, but these errors were encountered: