Skip to content

Commit 931a691

Browse files
authored
Merge pull request #2341 from hzeller/feature-20250121-stray-absl-stringview
Fix stray absl string_view dependency.
2 parents e90ef18 + 4c74243 commit 931a691

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

.github/bin/check-potential-problems.sh

+9-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,15 @@ EXIT_CODE=0
2121

2222
# absl has a string_view but there is also std::string_view.
2323
# Use the std::string_view throughout.
24-
find verible -name "*.h" -o -name "*.cc" | \
25-
xargs grep -n "absl::string_view"
24+
find verible -name "*.h" -o -name "*.cc" | xargs grep -n "absl::string_view"
25+
if [ $? -eq 0 ]; then
26+
echo "::error:: use std::string_view instead of absl::string_view"
27+
echo
28+
EXIT_CODE=1
29+
fi
30+
31+
# ... same for absl string_view dependency.
32+
find verible -name BUILD | xargs grep -n absl/strings:string_view
2633
if [ $? -eq 0 ]; then
2734
echo "::error:: use std::string_view instead of absl::string_view"
2835
echo

verible/common/util/BUILD

-1
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,6 @@ cc_library(
665665
hdrs = ["simple-zip.h"],
666666
deps = [
667667
"//third_party/portable_endian",
668-
"@abseil-cpp//absl/strings:string_view",
669668
"@zlib",
670669
],
671670
)

0 commit comments

Comments
 (0)