Skip to content

Commit ee15c8b

Browse files
Kuogee HsiehAbhinav Kumar
Kuogee Hsieh
authored and
Abhinav Kumar
committed
drm/msm/dp: assign correct DP controller ID to x1e80100 interface table
At current x1e80100 interface table, interface #3 is wrongly connected to DP controller #0 and interface #4 wrongly connected to DP controller #2. Fix this problem by connect Interface #3 to DP controller #0 and interface #4 connect to DP controller #1. Also add interface #6, #7 and #8 connections to DP controller to complete x1e80100 interface table. Changs in V3: -- add v2 changes log Changs in V2: -- add x1e80100 to subject -- add Fixes Fixes: e3b1f36 ("drm/msm/dpu: Add X1E80100 support") Signed-off-by: Kuogee Hsieh <[email protected]> Reviewed-by: Abhinav Kumar <[email protected]> Reviewed-by: Abel Vesa <[email protected]> Patchwork: https://patchwork.freedesktop.org/patch/585549/ Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Abhinav Kumar <[email protected]>
1 parent 4f3b77a commit ee15c8b

File tree

1 file changed

+31
-3
lines changed

1 file changed

+31
-3
lines changed

drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h

+31-3
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,7 @@ static const struct dpu_wb_cfg x1e80100_wb[] = {
324324
},
325325
};
326326

327+
/* TODO: INTF 3, 8 and 7 are used for MST, marked as INTF_NONE for now */
327328
static const struct dpu_intf_cfg x1e80100_intf[] = {
328329
{
329330
.name = "intf_0", .id = INTF_0,
@@ -358,8 +359,8 @@ static const struct dpu_intf_cfg x1e80100_intf[] = {
358359
.name = "intf_3", .id = INTF_3,
359360
.base = 0x37000, .len = 0x280,
360361
.features = INTF_SC7280_MASK,
361-
.type = INTF_DP,
362-
.controller_id = MSM_DP_CONTROLLER_1,
362+
.type = INTF_NONE,
363+
.controller_id = MSM_DP_CONTROLLER_0, /* pair with intf_0 for DP MST */
363364
.prog_fetch_lines_worst_case = 24,
364365
.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
365366
.intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31),
@@ -368,7 +369,7 @@ static const struct dpu_intf_cfg x1e80100_intf[] = {
368369
.base = 0x38000, .len = 0x280,
369370
.features = INTF_SC7280_MASK,
370371
.type = INTF_DP,
371-
.controller_id = MSM_DP_CONTROLLER_2,
372+
.controller_id = MSM_DP_CONTROLLER_1,
372373
.prog_fetch_lines_worst_case = 24,
373374
.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 20),
374375
.intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 21),
@@ -381,6 +382,33 @@ static const struct dpu_intf_cfg x1e80100_intf[] = {
381382
.prog_fetch_lines_worst_case = 24,
382383
.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 22),
383384
.intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 23),
385+
}, {
386+
.name = "intf_6", .id = INTF_6,
387+
.base = 0x3A000, .len = 0x280,
388+
.features = INTF_SC7280_MASK,
389+
.type = INTF_DP,
390+
.controller_id = MSM_DP_CONTROLLER_2,
391+
.prog_fetch_lines_worst_case = 24,
392+
.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17),
393+
.intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 16),
394+
}, {
395+
.name = "intf_7", .id = INTF_7,
396+
.base = 0x3b000, .len = 0x280,
397+
.features = INTF_SC7280_MASK,
398+
.type = INTF_NONE,
399+
.controller_id = MSM_DP_CONTROLLER_2, /* pair with intf_6 for DP MST */
400+
.prog_fetch_lines_worst_case = 24,
401+
.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 18),
402+
.intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 19),
403+
}, {
404+
.name = "intf_8", .id = INTF_8,
405+
.base = 0x3c000, .len = 0x280,
406+
.features = INTF_SC7280_MASK,
407+
.type = INTF_NONE,
408+
.controller_id = MSM_DP_CONTROLLER_1, /* pair with intf_4 for DP MST */
409+
.prog_fetch_lines_worst_case = 24,
410+
.intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12),
411+
.intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 13),
384412
},
385413
};
386414

0 commit comments

Comments
 (0)