finish integrating node bindings into core repository

don't ignore core sourcefiles,
prevented npm installation on architectures with no prebuild
don't run lint checks on windows
github actions don't like double quotes apparently
minimize node.js CI
update ubuntu runner to 22.04
README: update link to node bindings source
simplify link in readme
node: fix crash with invalid account id
(throw error when getContext failed)
fix typo in readme
remove node specific changelog
change prebuild machine back to ubuntu 18.04
move package.json to root level to include rust source in npm package
change path in m1 patch
github action to upload to download.delta.chat/node/ on tag
try build with ubuntu 20.04
Update node/README.md
try building it with newer ubuntu because it wants glibc 2.33
fix path for prebuildify script
throw error when instanciating a wrapper class on `null`
(Context, Message, Chat, ChatList and so on)
try fix selecting the right cache
to fix the strange glibc bug
also revert back ubuntu version to 18.04
also bump package.json version with release script
fix paths since we moved around package.json
github action: fix path
document npm release - it's so much easier now!
there are no PR checks to post to if this action is executed on a tag
github action: fix artifact names
fix paths? wtf do I know, it's 3AM and I'm drunk
fix syntax error
don't upload preview if action is run on tag
is the tag ID an empty string or null?
node-package github action is done so far
also include scripts in package
only publish docs on push to master branch
actually bump package.json version in set_core_version script
prettify package.json
fix test - we don't really need to assert that
remove unnecessary ls statement from github action

Author: missytake

.github/workflows/node-docs.yml

@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - master
-      - integrate-node-into-repo
 
 jobs:
   generate:

.github/workflows/node-package.yml

@@ -1,10 +1,14 @@
-name: 'Build node.js bindings from PR'
+name: 'node.js'
 on:
   pull_request:
+  push:
+    tags:
+    - '*'
+
 
 jobs:
   prebuild:
-    name: 'Prebuild'
+    name: 'Tests & Prebuild'
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
@@ -29,7 +33,7 @@ jobs:
           path: |
             ${{ env.APPDATA }}/npm-cache
             ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package.json') }}
+          key: ${{ matrix.os }}-node-${{ hashFiles('**/package.json') }}
 
       - name: Cache cargo index
         uses: actions/cache@v2
@@ -38,14 +42,28 @@ jobs:
             ~/.cargo/registry/
             ~/.cargo/git
             target
-          key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}-2
+          key: ${{ matrix.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}-2
 
       - name: Install dependencies & build
         if: steps.cache.outputs.cache-hit != 'true'
         run: |
           cd node
           npm install --verbose
 
+      - name: Test
+        if: runner.os != 'Windows'
+        run: |
+          cd node
+          npm run test
+        env:
+          DCC_NEW_TMP_EMAIL: ${{ secrets.DCC_NEW_TMP_EMAIL }}
+      - name: Run tests on Windows, except lint
+        if: runner.os == 'Windows'
+        run: |
+          cd node
+          npm run test:mocha
+        env:
+          DCC_NEW_TMP_EMAIL: ${{ secrets.DCC_NEW_TMP_EMAIL }}
       - name: Build Prebuild
         run: |
           cd node
@@ -60,7 +78,7 @@ jobs:
 
   pack-module:
     needs: prebuild
-    name: 'Package the node_module and upload as artifact for testing'
+    name: 'Package deltachat-node and upload to download.delta.chat'
     runs-on: ubuntu-18.04
     steps:
       - name: install tree
@@ -70,10 +88,19 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: '16'
+      - name: get tag
+        id: tag
+        uses: dawidd6/action-get-tag@v1
+        continue-on-error: true
       - name: Get Pullrequest ID
         id: prepare
         run: |
-          node -e "console.log('::set-output name=prid::' + '${{ github.ref }}'.split('/')[2])"
+          tag=${{ steps.tag.outputs.tag }}
+          if [ -z "$tag" ]; then
+            node -e "console.log('::set-output name=prid::' + '${{ github.ref }}'.split('/')[2])"
+          else
+            echo "No preview will be uploaded this time, but the $tag release"
+          fi
       - name: System info
         run: |
           rustc -vV
@@ -85,59 +112,59 @@ jobs:
         uses: actions/download-artifact@v1
         with:
           name: ubuntu-18.04
-          path: node/
       - name: Download macos prebuild
         uses: actions/download-artifact@v1
         with:
           name: macos-latest
-          path: node/
       - name: Download windows prebuild
         uses: actions/download-artifact@v1
         with:
           name: windows-latest
-          path: node/
       - shell: bash
         run: |
-          cd node
-          ls -lah
           mkdir prebuilds
-          tar -xvzf ubuntu-18.04.tar.gz -C prebuilds
-          tar -xvzf macos-latest.tar.gz -C prebuilds
-          tar -xvzf windows-latest.tar.gz -C prebuilds
+          tar -xvzf ubuntu-18.04/ubuntu-18.04.tar.gz -C prebuilds
+          tar -xvzf macos-latest/macos-latest.tar.gz -C prebuilds
+          tar -xvzf windows-latest/windows-latest.tar.gz -C prebuilds
           tree prebuilds
       - name: install dependencies without running scripts
         run: |
-          cd node
           npm install --ignore-scripts
       - name: build typescript part
         run: |
-          cd node
           npm run build:bindings:ts
       - name: package
         shell: bash
         run: |
-          cd node
           npm pack .
           ls -lah
           mv $(find deltachat-node-*) deltachat-node-${{ steps.prepare.outputs.prid }}.tar.gz
       - name: Upload Prebuild
         uses: actions/upload-artifact@v1
         with:
           name: deltachat-node.tgz
-          path: node/deltachat-node-${{ steps.prepare.outputs.prid }}.tar.gz
-      # Upload Step
-      - name: upload folder
-        id: upload
+          path: deltachat-node-${{ steps.prepare.outputs.prid }}.tar.gz
+      # Upload to download.delta.chat/node/preview/
+      - name: Upload deltachat-node preview to download.delta.chat/node/preview/
+        id: upload-preview
         shell: bash
         run: |
-          cd node
           echo -e "${{ secrets.SSH_KEY }}" >__TEMP_INPUT_KEY_FILE
           chmod 600 __TEMP_INPUT_KEY_FILE
-          scp -o StrictHostKeyChecking=no -v -i __TEMP_INPUT_KEY_FILE -P "22" -r deltachat-node-${{ steps.prepare.outputs.prid }}.tar.gz "${{ secrets.USERNAME }}"@"download.delta.chat":"/var/www/html/download/node/"
+          scp -o StrictHostKeyChecking=no -v -i __TEMP_INPUT_KEY_FILE -P "22" -r deltachat-node-${{ steps.prepare.outputs.prid }}.tar.gz "${{ secrets.USERNAME }}"@"download.delta.chat":"/var/www/html/download/node/preview/"
         continue-on-error: true
       - name: "Post links to details"
-        if: steps.upload.outcome == 'success'
+        if: steps.upload-preview.outcome == 'success'
         run: node ./node/scripts/postLinksToDetails.js
         env:
-         PR_ID: ${{ steps.prepare.outputs.prid }}
+         URL: preview/deltachat-node-${{ steps.prepare.outputs.prid }}
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      # Upload to download.delta.chat/node/
+      - name: Upload deltachat-node build to download.delta.chat/node/
+        if: ${{ steps.tag.outputs.tag }}
+        id: upload
+        shell: bash
+        run: |
+          echo -e "${{ secrets.SSH_KEY }}" >__TEMP_INPUT_KEY_FILE
+          chmod 600 __TEMP_INPUT_KEY_FILE
+          scp -o StrictHostKeyChecking=no -v -i __TEMP_INPUT_KEY_FILE -P "22" -r deltachat-node-${{ steps.prepare.outputs.prid }}.tar.gz "${{ secrets.USERNAME }}"@"download.delta.chat":"/var/www/html/download/node/"

.github/workflows/node-tests.yml

@@ -35,7 +35,7 @@ python/all-testaccounts.txt
 tmp/
 
 # from deltachat-node
-node/node_modules/
+node_modules/
 node/build/
 node/dist/
 node/prebuilds/

.gitignore

@@ -0,0 +1,42 @@
+.circleci/
+.gitmodules
+node/.nyc_output/
+.travis.yml
+appveyor.yml
+node/build/
+node/README.md
+rustfmt.toml
+spec.md
+test-data/
+build2/
+node_modules
+.git
+.idea/
+.pytest_cache
+CMakeLists.txt
+README.md
+contrib/
+node/ci_scripts/
+coverage/
+node/.circleci
+node/appveyor.yml
+ci/
+ci_scripts/
+python/
+target
+proptest-regressions
+deltachat-ffi/Doxyfile
+scripts
+webxdc.md
+standards.md
+draft/
+node/examples/
+# deltachat-core-rust/assets # don't exclude assets, otherwise it won't build
+node/images/
+node/test/
+node/windows.md
+node/*.tar.gz
+node/old_docs.md
+.vscode/
+.github/
+node/.prettierrc.yml

.npmignore

@@ -11,6 +11,16 @@
 - deprecate unused `marker1before` argument of `dc_get_chat_msgs`
   and remove `DC_MSG_ID_MARKER1` constant #3274
 
+### Added
+- Now the node-bindings are also part of this repository 🎉
+
+### Fixes
+- node: throw error when getting context with an invalid account id
+- node: throw error when instanciating a wrapper class on `null` (Context, Message, Chat, ChatList and so on)
+
+### Removed
+- node: remove unmaintained coverage scripts
+
 
 ## 1.80.0
 

node/.npmrc .npmrc

@@ -128,7 +128,7 @@ $ cargo test -- --ignored
 Language bindings are available for:
 
 - **C** \[[📂 source](./deltachat-ffi) | [📚 docs](https://c.delta.chat)\]
-- **Node.js** \[[📂 source](https://github.com/deltachat/deltachat-node) | [📦 npm](https://www.npmjs.com/package/deltachat-node) | [📚 docs](https://js.delta.chat)\]
+- **Node.js** \[[📂 source](./node) | [📦 npm](https://www.npmjs.com/package/deltachat-node) | [📚 docs](https://js.delta.chat)\]
 - **Python** \[[📂 source](./python) | [📦 pypi](https://pypi.org/project/deltachat) | [📚 docs](https://py.delta.chat)\]
 - **Go** \[[📂 source](https://github.com/deltachat/go-deltachat/)\]
 - **Free Pascal** \[[📂 source](https://github.com/deltachat/deltachat-fp/)\]