Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin installation, add enable/disable #2675

Closed
8 tasks done
jmontoyaa opened this issue Sep 18, 2018 · 0 comments · Fixed by #6127
Closed
8 tasks done

Improve plugin installation, add enable/disable #2675

jmontoyaa opened this issue Sep 18, 2018 · 0 comments · Fixed by #6127

Comments

@jmontoyaa
Copy link
Member

jmontoyaa commented Sep 18, 2018

Improve UI to plugin installation:

  • Remove checkbox and mass action list (post-alpha)

  • Add install/uninstall button (pre-alpha)

  • Add enable/disable button (doesn't delete all plugin table) (pre-alpha)

  • Modify "hook" to not fire events for disabled plugins (new EventListeners) and remove hooks files and tables (pre-alpha)

  • Do not parse disabled plugins in regions (active=0) (post-alpha)

  • Create new "plugin" table:

  • id (internal ID)

  • title (of the plugin, in slug form, like directory names in public/plugin/ now)

  • installed (0/1 - a bit redundant because only installed plugins should be there, but maybe when a plugin has been uninstalled it would be good to keep them there with a "0" value

  • installed_version (string in the semver format: https://semver.org/spec/v2.0.0.html)

  • source ('official'/'third_party')

  • Create new "access_url_rel_plugin" table

  • id (internal ID)

  • plugin_id (ref to plugin.id)

  • access_url_id (ref to access_url.id)

  • active (0/1) for this URL

  • configuration (JSON array with settings)

  • This will require a migration, as in v1 the plugins are "installed" through a settings_current entry, and sometimes enabled through another entry.

With this DB structure, any update to a new version of Chamilo will require scanning through the plugin table for plugins with installed = 1, and only for these check the difference between the "installed_version" field and the version documented inside the plugin files. If installed_version < text version, then execute the corresponding migrations (if any).

@jmontoyaa jmontoyaa added this to the 2.0 milestone Sep 18, 2018
@jmontoyaa jmontoyaa self-assigned this Sep 18, 2018
christianbeeznest added a commit to christianbeeznest/chamilo-lms that referenced this issue Mar 6, 2025
AngelFQC pushed a commit to AngelFQC/chamilo-lms that referenced this issue Mar 12, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC pushed a commit to AngelFQC/chamilo-lms that referenced this issue Mar 13, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC pushed a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
…talling chamilo#2675
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 17, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
@AngelFQC AngelFQC linked a pull request Mar 17, 2025 that will close this issue
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 18, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 18, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 18, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 18, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 19, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 19, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC pushed a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
…talling chamilo#2675
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit to AngelFQC/chamilo-lms that referenced this issue Mar 20, 2025

Verified

This commit was signed with the committer’s verified signature.
AngelFQC Angel Fernando Quiroz Campos
AngelFQC added a commit that referenced this issue Mar 20, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* Internal: Replacing hooks with event subscribers #2675

* Internal: Clean references to Hook system #2675

* Internal: Rename all HookEvent classes to Event classes #2675

* CI: Remove references to Hook classes #2675

* Internal: Improve plugin management UI & actions - refs #2675

* Internal: Use the Finder component to list plugins #2675

* Internal: Show plugin titles from each plugin info file #2675

* Internal: Allow to execute plugin configuration when installing/uninstalling #2675

* Internal: Allow to execute plugin configuration when installing #2675

* Internal: Remove SkypeEvent class #2675

* Internal: Change migration for plugin with settings by access url #2675

* Internal: Fix call to CourseCreatedEvent with course info #2675

* Internal: Add compiler pass to load plugin event subscribers #2675

* Internal: Remove hooks management from plugins #2675

* Internal: Add migration to drop hook_* tables #2675

* Internal: Plugin: Fix installation and activation process #2675

---------

Co-authored-by: Christian Beeznest <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants