Replies: 13 comments
-
"Menu" same. if try trigger before xx ms will can't trigger for open after pass xx ms. |
Beta Was this translation helpful? Give feedback.
-
Problem have been solved on "solid-js: 1.8.22" |
Beta Was this translation helpful? Give feedback.
-
It's not, here's a repro fork with bumped versions: |
Beta Was this translation helpful? Give feedback.
-
“solid.js 1.8.22” does not require EnvironmentProvider, Portal. |
Beta Was this translation helpful? Give feedback.
-
What do you mean it doesn't require Portals? What does that even mean?
…On Wed, 28 Aug 2024, 19:30 piyanggoon, ***@***.***> wrote:
It's not, here's a repro fork with bumped versions:
https://stackblitz.com/edit/github-3ajpxj-ncrtni
“solid.js 1.8.22” does not require EnvironmentProvider, Portal.
—
Reply to this email directly, view it on GitHub
<#2716 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVSGJ64AKKAV64URZDLGDLZTYCLPAVCNFSM6AAAAABL2XWEX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJVHEYDKMZZHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Beta Was this translation helpful? Give feedback.
-
https://stackblitz.com/edit/github-3ajpxj-ay5hlw?file=src%2FApp.tsx |
Beta Was this translation helpful? Give feedback.
-
My problem with using an older version of "solid.js" with Ark UI was that it couldn’t interact when loading js wasn’t finished. If tried to click before it finished, it would become unresponsive, like it was stuck. However, after upgrading "solid.js", the problem was resolved. |
Beta Was this translation helpful? Give feedback.
-
You misunderstood the issue it seems. Here is a repro sample with all the deps bumped: dependencies:
- @ark-ui/solid 3.5.0
+ @ark-ui/solid 3.10.0
- @kobalte/core 0.13.3
+ @kobalte/core 0.13.6
- solid-js 1.8.18
+ solid-js 1.8.22
devDependencies:
- typescript 5.5.3
+ typescript 5.5.4
- vite 5.3.4
+ vite 5.4.3 These are the requirements:
When these requirements are met, the repro is as follows:
|
Beta Was this translation helpful? Give feedback.
-
I am now able to reproduce this issue even without it being disabled at any point. It's definitely a race condition issue. Additionally, clicking the select field also seems to trigger the "click outside", leading to not being able to close the dropdown by clicking the select field. Screen_Recording_2024-09-20_at_17.09.45.mov |
Beta Was this translation helpful? Give feedback.
-
https://stackblitz.com/edit/solidjs-ark-shadow-root?file=src%2FApp.tsx A mitigation - clicking twice on mount of a custom trigger. |
Beta Was this translation helpful? Give feedback.
-
@ivancuric can you try with |
Beta Was this translation helpful? Give feedback.
-
@cschroeter Still exhibits the issue with |
Beta Was this translation helpful? Give feedback.
-
Why was this converted to a discussion from an issue? |
Beta Was this translation helpful? Give feedback.
-
Description
If a
Select.Root
is rendered inside a shadow root and starts asdisabled
, it will not respond to keyboard interactions until the trigger is clicked at least once.It's not only when it starts as disabled, but if it's disabled within 16ms of being rendered. Might be a race condition of some sort. In the repro, you can update the timeout of the disable to see the change in behaviour.
Link to Reproduction (or Detailed Explanation)
https://stackblitz.com/edit/github-3ajpxj-elxemr?file=src%2FApp.tsx
Steps to Reproduce
Fix 1: Click the trigger - further keyboard interactions will work
Fix 2: set the timeout of the disable to 16ms or more
Fix 3: Don't use shadow roots in the portal
Ark UI Version
3.6.2
Framework
Browser
Chrome
Additional Information
No response
Beta Was this translation helpful? Give feedback.
All reactions