Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the compiled archive com_mywalks.zip from the repo. #2

Open
shoulders opened this issue Oct 17, 2020 · 4 comments
Open

remove the compiled archive com_mywalks.zip from the repo. #2

shoulders opened this issue Oct 17, 2020 · 4 comments

Comments

@shoulders
Copy link

  • putting the zip in the file tree is confusing
  • Most people will use the download as zip option provided by Github

Thanks for the hard work

@ceford
Copy link
Owner

ceford commented Oct 18, 2020

I needed a way to download a zip that can be installed directly into joomla. The zip created by the download link in Github downloads a copy of the code complete with parent directory. I don't know how to make a Joomla installable zip in Git hub!

@shoulders
Copy link
Author

Are those images directly links to the repo from joomla? If not then you could use .gitignore and remove the from the repo. I have a localonly folder which is in the repo on my local machine but never uploaded and this is where I keep all of my related assets.

I have just double checked and if you download the file direct from github https://github.com/ceford/j4xdemos-com-mywalks/archive/master.zip (I then removed the extra zip file) the MyWalks component installs as normal on Joomla 4. It actually still installs with this extra zip inside (this is probaly ignored becasue a valid XML is found).

The installer searches the zip archive for all valid manifest files and then I think it runs the first one or ques them up in the case of a package. So although the resources are in the downloadable zip they are never copied into joomla. This perhaps would make things a little easier.

The other way people release their extensions is by creating a release and then uploading a binary/zip. However with this project being so dynamic I would avoid that. People who are downloading this example component understand that it is best not to have constantly updated versions.

If you make this change you have the following options:

  • install directly from github with https://github.com/ceford/j4xdemos-com-mywalks/archive/master.zip
  • install from your local repo folder c:\webhost\myrepo
  • manually make a zip, then install that
  • My options is that I use my Joomla symlink installer extension (currently on J3.x compatible) so I only ever have to install my extension once and can work on it live with my IDE on my local machine and then just commit the changes to Github.

@ceford
Copy link
Owner

ceford commented Oct 19, 2020

The images: I started writing the tutorial in the github Wiki and included the images for my convenience. Then I moved it all the Joomla docs site. All of this was my first serious use of Github - hence the bungled layout.

I have since written another tutorial: https://docs.joomla.org/Setting_up_Eclipse_PDT_2020_and_Git_for_Pulls - it seems to me that writing documentation is the best way of learning.

@shoulders
Copy link
Author

I have been using github for a while but I am no expert, it has taken me a while to get my head around things. I currently use netbeans on windows. I will have a look over your tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants