Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang 19 -Wc++20-extensions warning #2910

Open
ChrisThrasher opened this issue Sep 24, 2024 · 0 comments · May be fixed by #2934
Open

Clang 19 -Wc++20-extensions warning #2910

ChrisThrasher opened this issue Sep 24, 2024 · 0 comments · May be fixed by #2934
Labels
Warnings issue

Comments

@ChrisThrasher
Copy link
Collaborator

ChrisThrasher commented Sep 24, 2024 •
edited
Loading

Describe the bug
Clang reports a -Wc++20-extensions warning when expanding the TEMPLATE_TEST_CASE macro with the following message

/Users/thrasher/Projects/Catch2/tests/SelfTest/IntrospectiveTests/FloatingPoint.tests.cpp:27:1: error: passing no argument for the '...' parameter of a variadic macro is a C++20 extension [-Werror,-Wc++20-extensions]
   27 | TEMPLATE_TEST_CASE("type-shared ulpDistance tests", "[floating-point][ulp][approvals]", float, double) {
      | ^
/Users/thrasher/Projects/Catch2/src/catch2/../catch2/catch_template_test_macros.hpp:76:39: note: expanded from macro 'TEMPLATE_TEST_CASE'
   76 |     #define TEMPLATE_TEST_CASE( ... ) INTERNAL_CATCH_TEMPLATE_TEST_CASE( __VA_ARGS__ )
      |                                       ^
/Users/thrasher/Projects/Catch2/src/catch2/../catch2/internal/catch_template_test_registry.hpp:104:9: note: expanded from macro 'INTERNAL_CATCH_TEMPLATE_TEST_CASE'
  104 |         INTERNAL_CATCH_TEMPLATE_TEST_CASE_2( INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEMPLATE_TEST_ ), INTERNAL_CATCH_UNIQUE_NAME( CATCH2_INTERNAL_TEMPLATE_TEST_ ), Name, Tags, typename TestType, __VA_ARGS__ )
      |         ^
/Users/thrasher/Projects/Catch2/src/catch2/../catch2/internal/catch_template_test_registry.hpp:82:13: note: expanded from macro 'INTERNAL_CATCH_TEMPLATE_TEST_CASE_2'
   82 |             INTERNAL_CATCH_NTTP_GEN(INTERNAL_CATCH_REMOVE_PARENS(Signature))\
      |             ^
/Users/thrasher/Projects/Catch2/src/catch2/../catch2/internal/catch_preprocessor.hpp:217:465: note: expanded from macro 'INTERNAL_CATCH_NTTP_GEN'
  217 | #define INTERNAL_CATCH_NTTP_GEN(...) INTERNAL_CATCH_VA_NARGS_IMPL(__VA_ARGS__, INTERNAL_CATCH_NTTP_1(__VA_ARGS__), INTERNAL_CATCH_NTTP_1(__VA_ARGS__), INTERNAL_CATCH_NTTP_1(__VA_ARGS__), INTERNAL_CATCH_NTTP_1(__VA_ARGS__), INTERNAL_CATCH_NTTP_1(__VA_ARGS__), INTERNAL_CATCH_NTTP_1( __VA_ARGS__), INTERNAL_CATCH_NTTP_1( __VA_ARGS__), INTERNAL_CATCH_NTTP_1( __VA_ARGS__), INTERNAL_CATCH_NTTP_1( __VA_ARGS__),INTERNAL_CATCH_NTTP_1( __VA_ARGS__), INTERNAL_CATCH_NTTP_0)
      |                                                                                                                                                                                                                                                                                                                                                                                                                                                                                 ^
/Users/thrasher/Projects/Catch2/src/catch2/../catch2/internal/catch_preprocessor.hpp:100:9: note: macro 'INTERNAL_CATCH_VA_NARGS_IMPL' defined here
  100 | #define INTERNAL_CATCH_VA_NARGS_IMPL(_0, _1, _2, _3, _4, _5, _6, _7, _8, _9, _10, N, ...) N
      |         ^

Reproduction steps
I'm using the all-tests preset with Clang 19 as provided by Homebrew. I also encounter this issue when consuming Catch2 via FetchContent for use in various other projects.

Platform information:

  • OS: macOS 15
  • Compiler+version: Clang 19.1.0
  • Catch version: v3.7.1 fa43b77429ba76c462b1898d6cd2f2d7a9416b14
abhishekbelgaonkar23 added a commit to abhishekbelgaonkar23/Catch2 that referenced this issue Nov 16, 2024
@abhishekbelgaonkar23
fix: Clang 19 -Wc++20-extensions warning (catchorg#2910)
156d28e 
-Added INTERNAL_CATCH_TEMPLATE_TEST_CASE_HANDLE_EMPTY macro for Clang 19+
- Modified template test case macro expansion path for Clang 19+
- Keeps original behavior for other compilers and older Clang versions
abhishekbelgaonkar23 added a commit to abhishekbelgaonkar23/Catch2 that referenced this issue Nov 16, 2024
@abhishekbelgaonkar23
fix: Clang 19 -Wc++20-extensions warning in template test macros (cat…
2487da6 
…chorg#2910)

- Added INTERNAL_CATCH_TEMPLATE_TEST_CASE_HANDLE_EMPTY macro for Clang 19+
- Modified template test case macro expansion path for Clang 19+
- Keeps original behavior for other compilers and older Clang versions
@abhishekbelgaonkar23 abhishekbelgaonkar23 linked a pull request Nov 16, 2024 that will close this issue
Open
elbeno added a commit to elbeno/cicd-repo-infrastructure that referenced this issue Jan 14, 2025
@elbeno
⬆️ Update various dependencies
dfa4b51 
- Catch2: 3.6.0 -> 3.8.0
- CPM: 0.38.2 -> 0.40.2
- GoogleTest: 1.14.0 -> 1.15.2
- rapidcheck: 1c91f40 -> ff6af6f
- Snitch: 1.2.5 -> 1.3.1
- Mull: 0.23.0 -> 0.24.0

Note:
- Catch2 has a bug with C++17 and clang-19 detailed at catchorg/Catch2#2910
elbeno added a commit to elbeno/cicd-repo-infrastructure that referenced this issue Jan 14, 2025
@elbeno
⬆️ Update various dependencies
660a51c 
- Catch2: 3.6.0 -> 3.8.0
- CPM: 0.38.2 -> 0.40.2
- GoogleTest: 1.14.0 -> 1.15.2
- rapidcheck: 1c91f40 -> ff6af6f
- Snitch: 1.2.5 -> 1.3.1
- Mull: 0.23.0 -> 0.24.0
- Switch to clang-19 as the primary compiler for tests in this repo

Note:
- Catch2 has a bug with C++17 and clang-19 detailed at catchorg/Catch2#2910
elbeno added a commit to elbeno/cicd-repo-infrastructure that referenced this issue Jan 14, 2025
@elbeno
⬆️ Update various dependencies
0713f05 
- Catch2: 3.6.0 -> 3.8.0
- CPM: 0.38.2 -> 0.40.2
- GoogleTest: 1.14.0 -> 1.15.2
- rapidcheck: 1c91f40 -> ff6af6f
- Snitch: 1.2.5 -> 1.3.1
- Mull: 0.23.0 -> 0.24.0
- Switch to clang-19 as the primary compiler for tests in this repo

Note:
- A recent change to puppeteer caused mermaid doc image generation to fail. Fixed.
- Catch2 has a bug with C++17 and clang-19 detailed at catchorg/Catch2#2910
@elbeno elbeno mentioned this issue Jan 14, 2025
Merged
elbeno added a commit to elbeno/cicd-repo-infrastructure that referenced this issue Jan 14, 2025
@elbeno
⬆️ Update various dependencies
ed2151a 
- Catch2: 3.6.0 -> 3.8.0
- CPM: 0.38.2 -> 0.40.2
- GoogleTest: 1.14.0 -> 1.15.2
- rapidcheck: 1c91f40 -> ff6af6f
- Snitch: 1.2.5 -> 1.3.1
- Mull: 0.23.0 -> 0.24.0
- Switch to clang-19 as the primary compiler for tests in this repo

Note:
- A recent change to puppeteer caused mermaid doc image generation to fail. Fixed.
- Catch2 has a bug with C++17 and clang-19 detailed at catchorg/Catch2#2910
elbeno added a commit to elbeno/cicd-repo-infrastructure that referenced this issue Jan 14, 2025
@elbeno
⬆️ Update various dependencies
d5a4811 
- Catch2: 3.6.0 -> 3.8.0
- CPM: 0.38.2 -> 0.40.2
- GoogleTest: 1.14.0 -> 1.15.2
- rapidcheck: 1c91f40 -> ff6af6f
- Snitch: 1.2.5 -> 1.3.1
- Mull: 0.23.0 -> 0.24.0
- Switch to clang-19 as the primary compiler for tests in this repo

Note:
- A recent change to puppeteer caused mermaid doc image generation to fail. Fixed.
- Catch2 has a bug with C++17 and clang-19 detailed at catchorg/Catch2#2910
@SimeonEhrig SimeonEhrig mentioned this issue Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Warnings issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Clang 19 -Wc++20-extensions warning #2910 abhishekbelgaonkar23/Catch2
2 participants
@horenmar @ChrisThrasher