Skip to content

Commit da057ec

Browse files
feat: Add support for JDK 21 (#830)
1 parent 2873074 commit da057ec

File tree

4 files changed

+27
-9
lines changed

4 files changed

+27
-9
lines changed

.github/workflows/build.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ jobs:
5454
fail-fast: false
5555
matrix:
5656
os: [ ubuntu-latest, windows-latest, macos-latest ]
57-
java: [ 11, 17 ]
57+
java: [ 11, 17, 21 ]
5858
#os: [ ubuntu-latest ]
5959
#java: [ 11 ]
6060
steps:
@@ -84,7 +84,7 @@ jobs:
8484
notifications
8585
jdks
8686
build-scan-publish: true
87-
build-scan-terms-of-use-url: "https://gradle.com/help/legal-terms-of-use"
87+
build-scan-terms-of-use-url: "https://gradle.com/terms-of-service"
8888
build-scan-terms-of-use-agree: "yes"
8989

9090

@@ -136,7 +136,7 @@ jobs:
136136

137137
- name: Publish code analysis to Sonarcloud
138138
# [WARNING] The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
139-
if: ${{ matrix.os == 'ubuntu-latest' && matrix.java == '17' }}
139+
if: ${{ matrix.os == 'ubuntu-latest' && matrix.java == '21' }}
140140
env:
141141
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
142142
S3FS_PUBLISH_SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

README.md

+8-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,14 @@ This project provides a complete API implementation, for managing files and fold
3333

3434
## Compatibility
3535

36-
We support JDK 8, 11 and 17.
36+
We aim to support only the latest LTS versions. At the moment this includes:
37+
38+
* JDK 8
39+
* JDK 11
40+
* JDK 17
41+
* JDK 21
42+
43+
Please note that although we support JDK 8 we have plans to drop it in one of our next **major** release (most likely `v2.0.0`).
3744

3845
## Documentation
3946

src/main/java/org/carlspring/cloud/storage/s3fs/attribute/S3BasicFileAttributeView.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.carlspring.cloud.storage.s3fs.attribute;
22

33
import org.carlspring.cloud.storage.s3fs.S3Path;
4+
import org.slf4j.Logger;
5+
import org.slf4j.LoggerFactory;
46

57
import java.io.IOException;
68
import java.nio.file.attribute.BasicFileAttributeView;
@@ -11,6 +13,7 @@ public class S3BasicFileAttributeView
1113
implements BasicFileAttributeView
1214
{
1315

16+
private static final Logger log = LoggerFactory.getLogger(S3BasicFileAttributeView.class);
1417
private S3Path s3Path;
1518

1619

@@ -37,7 +40,8 @@ public void setTimes(FileTime lastModifiedTime,
3740
FileTime lastAccessTime,
3841
FileTime createTime)
3942
{
40-
// TODO: Not implemented
43+
// TODO: Implement
44+
log.debug(getClass() + "#setTimes() is not supported yet.");
4145
}
4246

4347
}

src/main/java/org/carlspring/cloud/storage/s3fs/attribute/S3PosixFileAttributeView.java

+11-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package org.carlspring.cloud.storage.s3fs.attribute;
22

33
import org.carlspring.cloud.storage.s3fs.S3Path;
4+
import org.slf4j.Logger;
5+
import org.slf4j.LoggerFactory;
46

57
import java.io.IOException;
68
import java.nio.file.attribute.*;
@@ -11,6 +13,7 @@ public class S3PosixFileAttributeView
1113
implements PosixFileAttributeView
1214
{
1315

16+
private static final Logger log = LoggerFactory.getLogger(S3PosixFileAttributeView.class);
1417
private S3Path s3Path;
1518

1619
private PosixFileAttributes posixFileAttributes;
@@ -44,25 +47,29 @@ public UserPrincipal getOwner()
4447
@Override
4548
public void setOwner(UserPrincipal owner)
4649
{
47-
throw new UnsupportedOperationException();
50+
// TODO: Implement
51+
log.debug(getClass() + "#setOwner() is not supported yet.");
4852
}
4953

5054
@Override
5155
public void setPermissions(Set<PosixFilePermission> perms)
5256
{
53-
throw new UnsupportedOperationException();
57+
// TODO: Implement
58+
log.debug(getClass() + "#setPermissions() is not supported yet.");
5459
}
5560

5661
@Override
5762
public void setGroup(GroupPrincipal group)
5863
{
59-
throw new UnsupportedOperationException();
64+
// TODO: Implement
65+
log.debug(getClass() + "#setGroup() is not supported yet.");
6066
}
6167

6268
@Override
6369
public void setTimes(FileTime lastModifiedTime, FileTime lastAccessTime, FileTime createTime)
6470
{
65-
// TODO: Not implemented
71+
// TODO: Implement
72+
log.debug(getClass() + "#setTimes() is not supported yet.");
6673
}
6774

6875
public PosixFileAttributes read()

0 commit comments

Comments
 (0)