Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly tries to parse HTML style escapes in file names when using expansion #1117

Closed
5 of 13 tasks
crabdancing opened this issue Mar 24, 2025 · 0 comments · Fixed by #1118
Closed
5 of 13 tasks
Labels
bug Something isn't working darwin fish fund Fundable with polar.sh linux nushell zsh

Comments

@crabdancing
Copy link

crabdancing commented Mar 24, 2025

Current Behavior

Tries to parse % as an HTML escape char. My guess is some internal mechanism needs the file path to be properly escaped before handling it?

[{"value":"--ERR","display":"ERR","description":"parse \"file:///tmp/test-files/hi%d\": invalid URL escape \"%d\"","style":{"fg":"red","attr":"b"}},{"value":"--_","display":"_"}]

Expected Behavior

Should not do that.

Steps To Reproduce

mkdir /tmp/test-files
cd /tmp/test-files
touch /tmp/test-files/hi%d
carapace ls nushell --

Gives us:

[{"value":"--ERR","display":"ERR","description":"parse \"file:///tmp/test-files/hi%d\": invalid URL escape \"%d\"","style":{"fg":"red","attr":"b"}},{"value":"--_","display":"_"}]

Also reproduced by @blindFS

Version

1.0.7

OS

  • Darwin
  • Linux
  • Termux
  • Windows

Shell

  • Bash
  • Cmd
  • Elvish
  • Fish
  • Nushell
  • Oil
  • Powershell
  • Xonsh
  • Zsh

Anything else?

No response

Polar

Fund with Polar
@crabdancing crabdancing added bug Something isn't working fund Fundable with polar.sh labels Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working darwin fish fund Fundable with polar.sh linux nushell zsh
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant