Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text max width in docs #514

Open
bartaz opened this issue Jan 22, 2024 · 2 comments
Open

Text max width in docs #514

bartaz opened this issue Jan 22, 2024 · 2 comments
Assignees
Labels

Comments

@bartaz
Copy link
Member

bartaz commented Jan 22, 2024

It seems that recent change removed max width limitation in docs (#487) in order to make it consistent with lists.

It should be fixed the other way around. Max width is there for a reason, to avoid lines of text that are too long to read comfortably.

There is a utility in Vanilla that allows to fix this (limit lists to paragraph text width): https://vanillaframework.io/docs/utilities/text-max-width. Please use it instead. (it can be used directly on list root element, or on any parent wrapper, if markup comes from discourse for example).

@chillkang
Copy link
Contributor

@bartaz In docs pages, there is notification component and table element so .text-max-width wouldn't be applied to those, right? I have removed p element from .docs #main-content { max-width: 40rem; } and would this be the right way to format the page?
Screenshot 2024-01-25 at 3 54 00 PM

@bartaz
Copy link
Member Author

bartaz commented Jan 25, 2024

@chillkang Yes, as notification and tables are block elements they are expected to be full width, while text elements (including lists) should be limited to 40rem.

As far as I've seen the proposed PR to updated documentation layout also addresses this issue: #510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants