Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Store Reference association is removed when changing type of subprocess #4862

Open
jarekdanielak opened this issue Feb 27, 2025 · 5 comments
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day ux

Comments

@jarekdanielak
Copy link
Contributor

Describe the bug

When I change the type of a subprocess, the associations between tasks inside of a subprocess and Data Store References are gone.

It doesn't happen to Data Store References inside of the subprocess or linked to the subprocess itself.

Screen.Recording.2025-02-27.at.12.00.56.mov

Steps to reproduce

  1. Create an expanded subprocess with a task.
  2. Add Data Store Reference to the task, put it outside of the subprocess.
  3. Change the type of the subprocess.
  4. The association between the task and the Data Store Reference is gone.

Expected behavior

The association stays.

Environment

  • OS: macOS
  • Camunda Modeler Version: 5.32

Additional context

No response

@jarekdanielak jarekdanielak added the bug Something isn't working label Feb 27, 2025
@barmac barmac added backlog Queued in backlog modeling ux spring cleaning Could be cleaned up one day labels Feb 27, 2025
@barmac
Copy link
Collaborator

barmac commented Feb 27, 2025

As we established, this is not a regression, but simply bad UX.

@barmac barmac added the good first issue Good for newcomers label Feb 27, 2025
@barmac
Copy link
Collaborator

barmac commented Feb 27, 2025

This needs to be fixed in bpmn-io/bpmn-js

@Buckwich Buckwich assigned Buckwich and unassigned Buckwich Mar 10, 2025
@Buckwich
Copy link
Member

During my testing I noticed that if you reopen a bpmn and try to change the type it behaves as expected. I guess the next step could be to write a test to dynamicly generate a broken bpmn and continue from there

@barmac
Copy link
Collaborator

barmac commented Mar 12, 2025

@Buckwich can you attach a link to the branch with a test case?

@Buckwich
Copy link
Member

@Buckwich can you attach a link to the branch with a test case?

Sorry forgot to at it https://github.com/bpmn-io/bpmn-js/tree/4862-removed-data-association

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

No branches or pull requests

3 participants