Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escalation boundary event is reported as unsupported for ad-hoc subprocess #4859

Open
barmac opened this issue Feb 26, 2025 · 6 comments
Open
Assignees
Labels
bug Something isn't working fixed upstream Requires integration of upstream change good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day

Comments

@barmac
Copy link
Collaborator

barmac commented Feb 26, 2025

Describe the bug

Image

We report incorrectly escalation boundary event as unsupported for ad-hoc subprocess. This is not true as the element can be attached to an ad-hoc subprocess. Only tasks cannot have escalation boundary events.

Steps to reproduce

  1. Create an ad-hoc subprocess
  2. Attach an escalation boundary event to it
  3. now this happens

Expected behavior

Report for tasks only. Also adjust the message.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: [e.g. 2.0.0]
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

Reported via slack: https://camunda.slack.com/archives/C0693F1NFK5/p1740574966727099

@barmac barmac added bug Something isn't working modeling labels Feb 26, 2025
@nikku nikku added ready Ready to be worked on good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Feb 26, 2025
@philippfromme
Copy link
Contributor

Likely a result of camunda/bpmnlint-plugin-camunda-compat#110.

@nikku
Copy link
Member

nikku commented Mar 11, 2025

Likely a result of camunda/bpmnlint-plugin-camunda-compat#110.

Which make it an easy thing to fix, thanks for the hint @philippfromme 🧁

@Buckwich Buckwich added the in progress Currently worked on label Mar 14, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the ready Ready to be worked on label Mar 14, 2025
@Buckwich
Copy link
Member

The current implementation is using exclusion (ie, for CallActivity, SubProcess, and now AdHocSubProcess the rule is not triggered). I don't think there are others we need to exclude now, just something to be aware of if we add more activities.

@barmac what do you mean with Also adjust the message.? In the case of a task it would already show this error message: Element of type <bpmn:BoundaryEvent> with event definition of type <bpmn:EscalationEventDefinition> is not allowed to be attached to element of type <bpmn:Task>

@philippfromme
Copy link
Contributor

philippfromme commented Mar 17, 2025

@Buckwich There is a second layer to linting which adjusts the error messages based on the assumption that they're going to be shown in the Problems tab. bpmnlint-plugin-camunda-compat can be used in a CLI which would lack the context of the modeler's UI. Therefore the default error messages are very technical and don't refer to entries in the properties panel and such. The usual workflow is

  1. Create the rule in bpmnlint-plugin-camunda-compat
  2. Adjust the error message and point to the right entry in the properties panel in @camunda/linting

For 1. you've already created the pull request so once that's integrated into @camunda/linting we can follow up with a pull request there.

philippfromme pushed a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Mar 17, 2025
Buckwich added a commit to camunda/bpmnlint-plugin-camunda-compat that referenced this issue Mar 17, 2025
Buckwich added a commit to camunda/linting that referenced this issue Mar 17, 2025
@Buckwich
Copy link
Member

@philippfromme @barmac I have released the new version of bpmnlint-plugin-camunda-compat and included it in camunda/linting#137. But I am still unsure what to do about the message as I didn't change the rule itself just reduced its occurence.

@Buckwich Buckwich added the fixed upstream Requires integration of upstream change label Mar 17, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the in progress Currently worked on label Mar 17, 2025
@barmac
Copy link
Collaborator Author

barmac commented Mar 17, 2025

In camunda/linting project, there's a utility which adjusts the generated error messages to be human-friendly (example: camunda/linting@23cc45a). The error message from the top comment is overly verbose, and hard to understand at the same time. This could be adjusted to a short, user-friendly alternative, e.g. "An attached to a is not supported in Camunda 8.7".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed upstream Requires integration of upstream change good first issue Good for newcomers modeling spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

4 participants