Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default start event for ad-hoc subprocess(expanded) as in collapsed #4858

Open
GeethaParthasarathy opened this issue Feb 26, 2025 · 4 comments
Assignees
Labels
BPMN bug Something isn't working good first issue Good for newcomers in progress Currently worked on modeling spring cleaning Could be cleaned up one day ux

Comments

@GeethaParthasarathy
Copy link

Describe the bug

When we create an expanded ad-hoc subprocess a start event is added to it as default just like in every other sub processes. But ad-hoc sub process does not allow events inside it and only allows task. This is the case when we directly create a collapsed ad-hoc subprocess where on drilling one level down we do not see any start event created by default.

Steps to reproduce

  1. Create an expanded ad-hoc sub process
  2. We could see that a start event is added by default and a lint error pops up for the user to remove the added start event
  3. Add a collapsed ad-hoc sub process on drilling down we do not see a default start event added to it
Screen.Recording.2025-02-26.at.10.32.39.mov

Expected behavior

Remove default start event for expanded sub process so that the user need not have to remove them as part of the lint error displayed

Environment

  • OS: [MacOS 10.2]
  • Camunda Modeler Version: [5.33 rc-1]
  • Execution Platform: [ Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Feb 26, 2025
@nikku
Copy link
Member

nikku commented Feb 26, 2025

Should absolutely be fixed, thanks for reporting. CC @jarekdanielak, maybe we can smoothen this in the near future?

@nikku nikku added BPMN modeling ux good first issue Good for newcomers spring cleaning Could be cleaned up one day ready Ready to be worked on labels Feb 26, 2025
@Buckwich
Copy link
Member

Would it make sense to add an activity instead of the start event? Otherwise the linter complains about that missing (in camunda 8.7 and higher)

Image

@barmac
Copy link
Collaborator

barmac commented Mar 14, 2025

Would it make sense to add an activity instead of the start event? Otherwise the linter complains about that missing (in camunda 8.7 and higher)

Activity is a grouping term for multiple element types:

  • tasks (blank, service, script... subtypes)
  • subprocesses (ad-hoc, transaction, event...)

Which one would you choose and why?

In the case of a subprocess, it's clear because it can contain only blank start events.

@Buckwich
Copy link
Member

I would have used a blank task as a starting default as its the first valid activity (i think gateway wouldn't make much sense). But I don't know if that would align with our users needs.
I think we should leave it empty then, ans the user needs to decide. That would also be consistent with the other variants (eg collapsed)

@Buckwich Buckwich added the in progress Currently worked on label Mar 17, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the ready Ready to be worked on label Mar 17, 2025
Buckwich added a commit to bpmn-io/bpmn-js that referenced this issue Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN bug Something isn't working good first issue Good for newcomers in progress Currently worked on modeling spring cleaning Could be cleaned up one day ux
Projects
None yet
Development

No branches or pull requests

5 participants