Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align search order for user tasks with the new improved search #4856

Open
GeethaParthasarathy opened this issue Feb 26, 2025 · 7 comments
Open
Assignees
Labels
bug Something isn't working in progress Currently worked on ux

Comments

@GeethaParthasarathy
Copy link

Describe the bug

When we search for tasks inside the create/append menu we could see that it is always displayed in the following order of simple tasks and then connector tasks but in case of User task the order is always vice versa

Steps to reproduce

  1. Click on the create/append menu
  2. Add the search team "form"
  3. We could see that the connector tasks are displayed first in the list and then the user task
  4. This is not the case for other task types like call activity/business rule tasks where the order is first basic tasks and then connector tasks
Screen.Recording.2025-02-26.at.10.28.32.mov

Expected behavior

Align the search order for user tasks as like other tasks

Environment

  • OS: [ MacOS 10.2]
  • Camunda Modeler Version: [5.33 rc-1]
  • Execution Platform: [Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Feb 26, 2025
@barmac barmac added the ready Ready to be worked on label Feb 27, 2025 — with bpmn-io-tasks
@barmac barmac added the ux label Feb 27, 2025
@Buckwich Buckwich self-assigned this Mar 19, 2025
@Buckwich Buckwich added the in progress Currently worked on label Mar 19, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the ready Ready to be worked on label Mar 19, 2025
@barmac
Copy link
Collaborator

barmac commented Mar 20, 2025

@nikku
Copy link
Member

nikku commented Mar 20, 2025

Or it might be in the core, i.e. PopupMenuComponent.

@Buckwich
Copy link
Member

Buckwich commented Mar 25, 2025

The issue seems to be that the search sorter focuses only on the first key, if that one already gives a difference. This means in most cases only the title is used for sorting, description and search (contains form human) are not relevant for sorting.

Proposed solution (discussed with nikku):

@nikku
Copy link
Member

nikku commented Mar 26, 2025

The sr command does not work for me, likely because diagram-js is a dependency of the camunda-modeler/client.

@nikku
Copy link
Member

nikku commented Mar 26, 2025

I'm testing now with bpmn-js:

npx @bpmn-io/sr "bpmn-io/bpmn-js" -l "bpmn-io/diagram-js#4856-adjust-result-sorter"  -c 'npm run dev'

@nikku
Copy link
Member

nikku commented Mar 26, 2025

@Buckwich Do we have a bigger example in the diagram-js tests in place that allows us to validate this E2E? I could imagine we simply add an integration test there, to be able to verify locally against a "close to real world" example.

@Buckwich
Copy link
Member

Do we have a bigger example in the diagram-js tests in place that allows us to validate this E2E? I could imagine we simply add an integration test there, to be able to verify locally against a "close to real world" example.

Not yet as I'm still trying out to find the best search, I think with [] support it would behave like I want it too. I guess I can add some tests just to verify I don't break too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in progress Currently worked on ux
Projects
None yet
Development

No branches or pull requests

4 participants