Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field suggestions in form playground input lead to validation error #4758

Open
barmac opened this issue Dec 13, 2024 · 6 comments
Open

Field suggestions in form playground input lead to validation error #4758

barmac opened this issue Dec 13, 2024 · 6 comments
Assignees
Labels
backlog Queued in backlog bug Something isn't working Forms ux

Comments

@barmac
Copy link
Collaborator

barmac commented Dec 13, 2024

Describe the bug

In the form playground input, I can provide a JSON for the variables. The editor suggests the form fields keys, but as soon as they are added, the JSON is invalid. This leads to bad UX.

image

Steps to reproduce

  1. Add a form field
  2. Start typing in JSON input.
  3. now this happens

Expected behavior

No suggestions beyond valid JSON values (e.g. null, true, false).

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.29.0, 5.30.0, maybe even earlier.
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@barmac barmac added bug Something isn't working ux Forms labels Dec 13, 2024
@nikku
Copy link
Member

nikku commented Jan 2, 2025

CC @camunda/human-task-orchestration-dev, please double-check if you can reproduce this issue.

@nikku nikku added the backlog Queued in backlog label Jan 2, 2025
@vsgoulart vsgoulart self-assigned this Feb 7, 2025
@vsgoulart
Copy link
Contributor

I'll check this next week

@vsgoulart
Copy link
Contributor

@nikku @barmac I worked a bit on the autocomplete, I would like some feedback on it before merging the PR.
Besides what was mentioned on this issue I fixed the variable autocompletion inside object and added quotes on the property name.

For the values besides the ones @barmac mentioned I added empty objects and arrays too.

Here's the preview env: https://demo-fix-form-input-autocomple--camunda-form-playground.netlify.app/

@nikku
Copy link
Member

nikku commented Feb 11, 2025

I found one bug that removes the focus from the key field, is this caused by the completion work?

Image

@vsgoulart
Copy link
Contributor

@nikku This is also happening in main, I'll create an issue for it

@nikku
Copy link
Member

nikku commented Feb 12, 2025

Checked the suggested auto completion in more details. The new suggestions are simple enough, and fix the issue. Overall, massive kudos, I think the playground goes quite some length to support users (using smart auto-completion) 🎉

Image


Some input on the current completion functionality (beyond this bug fix):

  • Key completion could move beyond ", insert :, it already does that outside of "":

Image

Image

  • We could complete actual values based off the data model that we inferred, consider for example dynamic mailtoOptions, we know exactly how such input would need to look like

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog bug Something isn't working Forms ux
Projects
None yet
Development

No branches or pull requests

3 participants