Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition is incompatible with TypeScript 4.9 #91

Closed
TechQuery opened this issue Nov 21, 2022 · 2 comments
Closed

Type definition is incompatible with TypeScript 4.9 #91

TechQuery opened this issue Nov 21, 2022 · 2 comments

Comments

@TechQuery
Copy link

TechQuery commented Nov 21, 2022

Expect

Build successfully with TypeScript 4.9:

{
    "compilerOptions": {
        "strict": true,
        "target": "ES5",
        "module": "ES2022",
        "moduleResolution": "Node",
        "jsx": "react-jsx",
        "jsxFactory": "",
        "jsxFragmentFactory": "",
        "lib": ["ES2022", "DOM"]
    },
    "include": ["source/**/*"],
}

Actual

node_modules/.pnpm/[email protected]/node_modules/element-internals-polyfill/dist/types.d.ts:56:18 - error 
TS2430: Interface 'ICustomElement' incorrectly extends interface 'HTMLElement'.
  The types returned by 'attachInternals()' are incompatible between these types.
    Type 'ElementInternals' is missing the following properties from type 'ElementInternals': ariaColIndexText, ariaInvalid, ariaRowIndexText

56 export interface ICustomElement extends HTMLElement {
                    ~~~~~~~~~~~~~~

 ELIFECYCLE  Command failed with exit code 3.

If I rollback to [email protected], this error disappears.

Environment

Software Version(s)
Node 16.18.0
PNPM 7.16.0
Operating System Windows 10 Pro 21H2
@calebdwilliams
Copy link
Owner

This should be fixed in the latest version (1.1.18).

@TechQuery
Copy link
Author

TechQuery commented Sep 5, 2024

This should be fixed in the latest version (1.1.18).

@calebdwilliams I think this bug hasn't been fixed:

node_modules/.pnpm/[email protected]/node_modules/element-internals-polyfill/dist/types.d.ts:60:18 - error TS2430: Interface 'ICustomElement' incorrectly extends interface 'HTMLElement'.
  The types returned by 'attachInternals()' are incompatible between these types.
    Type 'ElementInternals' is missing the following properties from type 'ElementInternals': ariaBrailleLabel, ariaBrailleRoleDescription

60 export interface ICustomElement extends HTMLElement {
                    ~~~~~~~~~~~~~~

this is my current environment:

  System:
    OS: Windows 11 10.0.22631
  Binaries:
    Node: 20.15.1 - C:\Program Files\nodejs\node.EXE
    npm: 10.7.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.9.0 - ~\AppData\Roaming\npm\pnpm.CMD
  Utilities:
    Git: 2.45.2. - /mingw64/bin/git
  SDKs:
    Windows SDK:
      AllowDevelopmentWithoutDevLicense: Enabled
  Languages:
    Bash: 5.2.26 - C:\Program Files\Git\usr\bin\bash.EXE
    Perl: 5.38.2 - C:\Program Files\Git\usr\bin\perl.EXE
  Browsers:
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.22621.3527

and the reproduce code is here: FreeCodeCamp-Chengdu/Web-Conf#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants