Skip to content

Commit 0b053c4

Browse files
committed
Parse app config strictly
In #3376 we switched `UnmarshalYAMLStrict` to `UnmarshalYAMLNonStrict`. I'm not entirely sure if this was intentional, but we want this to be strict by default. Happy to discuss if the CLI needs non-strict anywhere and if so if we can make this configurable.
1 parent f9da74e commit 0b053c4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

private/pkg/app/appext/appext.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ func ReadConfig(container NameContainer, value interface{}) error {
167167
if err != nil {
168168
return fmt.Errorf("could not read %s configuration file at %s: %w", container.AppName(), configFilePath, err)
169169
}
170-
if err := encoding.UnmarshalYAMLNonStrict(data, value); err != nil {
170+
if err := encoding.UnmarshalYAMLStrict(data, value); err != nil {
171171
return fmt.Errorf("invalid %s configuration file: %w", container.AppName(), err)
172172
}
173173
}

0 commit comments

Comments
 (0)