Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only output the GLS int type if possible #4

Open
JoshuaKGoldberg opened this issue Sep 29, 2017 · 2 comments
Open

Only output the GLS int type if possible #4

JoshuaKGoldberg opened this issue Sep 29, 2017 · 2 comments
Assignees
@JoshuaKGoldberg
Labels
bug

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Sep 29, 2017 •
edited
Loading

All JavaScript/TypeScript numerics may be changed at any time to float-style values from integers. Similar to not outputting arrays, this needs to stop.
@JoshuaKGoldberg JoshuaKGoldberg changed the title Stop outputting the GLS int type Only output the GLS int type if possible Oct 2, 2017
@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Oct 2, 2017 •
edited
Loading

...but on the other hand, it looks very odd to output for numbers start : i float 0 7. getNumericTypeNameFromNode should actually retrieve all usages of the node, so that if it's not exported publicly, and never modified in its scope, it correctly gets set to int.

@JoshuaKGoldberg
Copy link
Member Author

This is particularly relevant with C# string and array indices: they don't accept floats.

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg