-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG height is 684? #35
Comments
Each pattern determines its own dimensions based on what will tile (example), and those should be changing based on each input string. Can you provide a few more examples of input strings that all produce tiles with the same dimensions so I can see what's going on? |
Ahhh. Well, I am using UUIDs to generate unique backgrounds for my users (e.g., So I don't think the problem is that some tiles are tall and skinny – it's that I cannot enforce aspect ratio or arbitrary height/widths in the generated SVG (although I explicitly use the base64 data). If the SVG "viewport" can be simply cut-off at any height or width prior to generating the base64 data, the tiling remains in tact and I don't end up with weird design issues. |
Are you able to put together a codesandbox that demonstrates the issue it’s causing with your layout? This was built with browser background tiling in mind, so I’m not surprised it’s hard to use in places that affect layout. If you’re not able to let it tile or adjust the dimensions or overflow somehow, I believe a library like Trianglify would give you abstract backgrounds for known dimensions. |
I might be able to put something together. I can't go into great detail but the use case constraints come from it being a webview within a mobile app where the style guidelines in place are quite strict. It might be tough for me to get those image style rules changed. I don't want to ask you to bastardize your library on my behalf, I'll check out Trianglify in the meantime. |
I'm not sure what's going on, but I have generated several patterns and they always resolve to the SVG height being 684 with a width of 100.
Output
Paste the output into your browser location bar – you'll see that it's 100x684. What's going on here?
I'd expect it to at least return 100x100, maybe with an option of supplying my own height & width to better define the tile pattern.
The text was updated successfully, but these errors were encountered: