Deprecate UMASK_SET in favor of UMASK in baseimage

Author: Roxedus

Diff for: README.md

@@ -232,6 +232,7 @@ Once registered you can define the dockerfile to use with `-f Dockerfile.aarch64
 
 ## Versions
 
+* **29.01.21:** - Deprecate `UMASK_SET` in favor of UMASK in baseimage, see above for more information.
 * **23.01.21:** - Rebasing to alpine 3.13.
 * **15.09.20:** - Use go from alpine edge repo to compile. Remove duplicate UMASK env var. Add hostname setting.
 * **01.06.20:** - Rebasing to alpine 3.12.

Diff for: readme-vars.yml

@@ -42,6 +42,7 @@ app_setup_nginx_reverse_proxy_block: ""
 # changelog
 
 changelogs:
+  - { date: "29.01.21:", desc: "Deprecate `UMASK_SET` in favor of UMASK in baseimage, see above for more information." }
   - { date: "23.01.21:", desc: "Rebasing to alpine 3.13." }
   - { date: "15.09.20:", desc: "Use go from alpine edge repo to compile. Remove duplicate UMASK env var. Add hostname setting." }
   - { date: "01.06.20:", desc: "Rebasing to alpine 3.12." }

Diff for: root/etc/services.d/syncthing/run

@@ -1,7 +1,8 @@
 #!/usr/bin/with-contenv bash
 
-if [ -n "$UMASK_SET" ]; then
-	umask "$UMASK_SET"
+if [ -n "${UMASK_SET}" ] && [ -z "${UMASK}" ]; then
+  echo -e "You are using a legacy method of defining umask\nplease update your environment variable from UMASK_SET to UMASK\nto keep the functionality after July 2021"
+  umask ${UMASK_SET}
 fi
 
 exec \