From 141dd6e709fdacab6ee2204aa809bd38fdee9f8d Mon Sep 17 00:00:00 2001 From: Nassereddine <119059908+nassereddinebelghith@users.noreply.github.com> Date: Sat, 15 Feb 2025 16:22:54 +0100 Subject: [PATCH 1/3] (fix) Postgres latest stable version Add latest stable postgres supported version --- checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py b/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py index 59734da0f8a..a8a94b588be 100644 --- a/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py +++ b/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py @@ -14,7 +14,7 @@ def get_inspected_key(self): return 'database_version' def get_expected_values(self): - return ["POSTGRES_16", "MYSQL_8_0", "SQLSERVER_2022_STANDARD", "SQLSERVER_2022_WEB", + return ["POSTGRES_17", "MYSQL_8_0", "SQLSERVER_2022_STANDARD", "SQLSERVER_2022_WEB", "SQLSERVER_2022_ENTERPRISE", "SQLSERVER_2022_EXPRESS"] From d9742a2729baa375a61362f3bae18dd4e7d780c9 Mon Sep 17 00:00:00 2001 From: nassereddinebelghith Date: Sun, 16 Feb 2025 03:03:40 +0100 Subject: [PATCH 2/3] fix(terraform): UT for postgres 17 --- .../checks/resource/gcp/example_CloudSqlMajorVersion/main.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/terraform/checks/resource/gcp/example_CloudSqlMajorVersion/main.tf b/tests/terraform/checks/resource/gcp/example_CloudSqlMajorVersion/main.tf index 5e1f061df93..031629c33ea 100644 --- a/tests/terraform/checks/resource/gcp/example_CloudSqlMajorVersion/main.tf +++ b/tests/terraform/checks/resource/gcp/example_CloudSqlMajorVersion/main.tf @@ -94,7 +94,7 @@ resource "google_sql_database_instance" "fail2" { } resource "google_sql_database_instance" "pass2" { - database_version = "POSTGRES_16" + database_version = "POSTGRES_17" name = "general-pos121" project = "gcp-bridgecrew-deployment" region = "us-central1" From 6dfd98f6a505e7ed01e4b60837a53e02edd380a7 Mon Sep 17 00:00:00 2001 From: Taylor <28880387+tsmithv11@users.noreply.github.com> Date: Sat, 15 Feb 2025 21:49:01 -0800 Subject: [PATCH 3/3] Update checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py --- checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py b/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py index a8a94b588be..ddbe51cec87 100644 --- a/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py +++ b/checkov/terraform/checks/resource/gcp/CloudSqlMajorVersion.py @@ -14,7 +14,7 @@ def get_inspected_key(self): return 'database_version' def get_expected_values(self): - return ["POSTGRES_17", "MYSQL_8_0", "SQLSERVER_2022_STANDARD", "SQLSERVER_2022_WEB", + return ["POSTGRES_17", "MYSQL_8_0", "MYSQL_8_4", "SQLSERVER_2022_STANDARD", "SQLSERVER_2022_WEB", "SQLSERVER_2022_ENTERPRISE", "SQLSERVER_2022_EXPRESS"]