Skip to content

Commit d098ee0

Browse files
committed
[Android] Modularize bookmarks browser code
Chromium change: https://chromium.googlesource.com/chromium/src/+/088816e5c47905f8b4e16dd867cddaf24fb4f55f [bookmarks] Modularize bookmarks browser code Moved production bookmarks browser code to chrome/browser/bookmarks directory. Made some small changes along the way to simplify the process. * Moved all production bookmarks browser code to module. * Added a separate target for files that can be modularized now. * Added a separate gni list for files that can't be modularized now which is included in chrome_java directly. Over time I will refactor those files so that they are moved into the main modularized target. * Merged ReadingListUtils and BookmarkUtils. In the long run, browser reading list code shouldn't really exist since the concepts are merged at the native level. * Moved one method from BookmarkUtils to BookmarkModel to allow for more files to be modularized. Eventually some files, particularly implementations of interfaces defined in chrome/browser/bookmarks, will live in the unmodularized directory. Bug: 395908100
1 parent d7e2528 commit d098ee0

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

build/android/bytecode/bytecode_rewriter.gni

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ brave_bytecode_jars = [
2222
"obj/chrome/android/base_module_java.javac.jar",
2323
"obj/chrome/android/chrome_java.javac.jar",
2424
"obj/chrome/android/features/tab_ui/java.javac.jar",
25+
"obj/chrome/browser/bookmarks/android/java.javac.jar",
2526
"obj/chrome/browser/download/internal/android/java.javac.jar",
2627
"obj/chrome/browser/flags/java.javac.jar",
2728
"obj/chrome/browser/hub/internal/java.javac.jar",

test/BUILD.gn

+1
Original file line numberDiff line numberDiff line change
@@ -1289,6 +1289,7 @@ if (is_android) {
12891289
"//chrome/browser/android/browserservices/intents:java",
12901290
"//chrome/browser/android/lifecycle:java",
12911291
"//chrome/browser/back_press/android:java",
1292+
"//chrome/browser/bookmarks/android:java",
12921293
"//chrome/browser/browser_controls/android:java",
12931294
"//chrome/browser/contextmenu:java",
12941295
"//chrome/browser/data_sharing:data_sharing_public_java",

0 commit comments

Comments
 (0)