Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deadlock issue in verification flow #41

Closed
DJAndries opened this issue Mar 6, 2025 · 0 comments · Fixed by #42
Closed

Deadlock issue in verification flow #41

DJAndries opened this issue Mar 6, 2025 · 0 comments · Fixed by #42
Assignees
@DJAndries
Labels
bug Something isn't working

Comments

@DJAndries
Copy link
Collaborator

DJAndries commented Mar 6, 2025 •
edited
Loading

A race condition between the second goroutine in Datastore.StartVerificationEventListener and the user clicking on the verification link can cause all future verification result requests to hang forever.

Steps to reproduce:

  1. Comment out the second goroutine in Datastore.StartVerificationEventListener
  2. Request an email verification
  3. Call the verification result endpoint with wait set to true. Wait 20 seconds for the request to elapse
  4. Click on the email verification link
  5. Request another email verification, call the verification result endpoint with wait set to true. The request and all other future result requests will hang forever until the server restarts.
@DJAndries DJAndries added the bug Something isn't working label Mar 6, 2025
@DJAndries DJAndries self-assigned this Mar 6, 2025
@DJAndries DJAndries mentioned this issue Mar 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DJAndries DJAndries

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deadlock issue in verification flow brave/accounts
1 participant
@DJAndries