Adding more arguments to the jinxes

[MRegnard]

Hi!

Actually, each jinx has two arguments:

• second
• reason

But I was thinking about adding some other arguments to them:

• setup, boolean. The goal of this possible argument would be: when the ST assign roles, printing as a reminder the jinxes which affect the setup.
• reminder, string. This would be to add some useful reminders according to jinxes. For example, a Djinn's reminder "Poisoned" if both Spy and Damsel are on the script.

I was trying to add the argument "reminder", and it didn't work.
If I understood correctly, it is because the jinxes are Maps (and so, "second" is the key, while "reason" is the value for this key, which explains why jinxes cannot have more than two arguments).

To be honest, for the reminder, I find another solution, by complexioning a little the argument "reason". But even if it works, it is less readable as a solution with a new argument. And I never had this issue while trying to add arguments in the role.

So, did I understand the issue correctly? If yes, the jinxes are saved as Maps, but then how are saved the roles? And isn't it possible to edit the format of the jinxes to use the same format?

[bra1n]

Hey there,
the Jinxes (hatred.json) are parsed here:

  jinxes = new Map(
    jinxesJSON.map(({ id, hatred }) => [
      clean(id),
      new Map(hatred.map(({ id, reason }) => [clean(id), reason]))
    ])
  );

As you can see, they are turned into a 2 dimensional collection of Maps: Map(first character ID, Map(second character ID, reason)). This means you can access Jinxes like so: jinxes.get("boffin").get("drunk") returns the Boffin/Drunk Jinx "reason". Adding more complexity to this format would require you to return an object, rather than a string, for the inner Map. It's not impossible to do, but would require quite a bit of refactoring.

[MRegnard]

require you to return an object, rather than a string, for the inner Map

Did you mean "an object, rather than a Map"? Reading your comment, I first thought that I only have to change the line 68 of src/store/index.js to have an Object instead of a Map (I have also to change the files who use it, like ReferenceModal.vue, but this is something I can easily correct on my own). In fact, I first wrote a reply to ask you how I must change the line 68 of index.js, because I was really sure it was the only difficulty.

But then I saw you said "an object, rather than a string". Does that mean that I have to totally rework the file hatred.json? If yes, it will indeed be very hard to correct it... 🤔

[bra1n]

I meant replacing the plain reason string with an object, that contains the reason any any other meta parameters for this jinx.
And yes, you'd have to rework the whole hatred.json file for this.

[MRegnard]

Ah? hatred.json and roles.json are so similar that I didn't think I have to change hatred to have an object.
But if you say so... I guess the change is too complex to worth it.