maximum recursion depth exceeded in width_aware_slice

[sshilovsky]

>>> FmtStr(u'').width_aware_slice(0)
RuntimeError: maximum recursion depth exceeded

expected:

IndexError

>>> FmtStr(u'').width_aware_slice(slice(0, 100, None))
RuntimeError: maximum recursion depth exceeded

expected:

FmtStr(u'')

curtsies 0.2.6, python 2.7

[thomasballinger]

Hm that's sure not great.

This is because FmtStr's constructor doesn't take unicode strings, and should not be directly constructed. Instead, use

>>> from curtsies.formatstring import fmtstr
>>> f = fmtstr(u'asdf')
>>> f.width_aware_slice(2)
'd'

However this is very confusing. I'll look at doing a typecheck in the constructor, and at least adding a docstring. There are some typechecks currently in the code that have been commented out because they were killing performance.

If I designed this again I would absolutely use a classmethod for this instead and use something like fmtstr for the constructor.

[thomasballinger]

Closed because I'm not changing the (poor) api anytime soon.