Clean up both wakeup_fds #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasballinger
force-pushed
the
close-fd-pipe
branch
from
454a902 to
1e22440
Compare
sebastinas
reviewed
Dec 5, 2021
| @@ -135,7 +137,12 @@ def __exit__( | |||
| ): | |||
| signal.signal(signal.SIGINT, self.orig_sigint_handler) | |||
| if sys.version_info[0] == 3 and sys.version_info[1] > 4: | |||
| signal.set_wakeup_fd(-1) | |||
| if threading.current_thread() is threading.main_thread(): | |||
There was a problem hiding this comment.
There is is_main_thread in the same file.
|
Rebased and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is covering everything yet, but it fixes the cleanup problem.
Careful, this test doesn't run in CI right now, use
pytest -s --doctest-modules ./curtsies ./teststo run all tests locally.Fixes #170