Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element is not connected, implicit start/end are incorrect in ad-hoc subprocess #180

Closed
barmac opened this issue Mar 14, 2025 · 5 comments · Fixed by #181
Closed

Element is not connected, implicit start/end are incorrect in ad-hoc subprocess #180

barmac opened this issue Mar 14, 2025 · 5 comments · Fixed by #181
Assignees
@Buckwich
Labels
bug Something isn't working good first issue Good for newcomers rules Concerning existing or missing rules

Comments

@barmac
Copy link
Member

barmac commented Mar 14, 2025

Describe the Bug

Rules on implicit start/end, element not connected are misleading in ad-hoc subprocess. They should not be applied at all.

Image

Steps to Reproduce

  1. Create ad-hoc subprocess
  2. Place a task inside
  3. now this happens

Expected Behavior

Rules should not apply.

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@barmac barmac added bug Something isn't working rules Concerning existing or missing rules ready Ready to be worked on labels Mar 14, 2025
@nikku nikku added the good first issue Good for newcomers label Mar 14, 2025
@Buckwich Buckwich self-assigned this Mar 19, 2025
@Buckwich Buckwich added the in progress Currently worked on label Mar 19, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the ready Ready to be worked on label Mar 19, 2025
@Buckwich
Copy link
Member

@barmac I was not able to reproduce this. Could it be already fixed by our recent updates to linting (eg #176)? Or in which application did you test this?

@nikku
Copy link
Member

nikku commented Mar 19, 2025

Fixed via #176, I believe.

@nikku nikku mentioned this issue Mar 19, 2025
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot closed this as completed Mar 19, 2025
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Mar 19, 2025
@barmac
Copy link
Member Author

barmac commented Mar 19, 2025

It's not fixed. The rules changed in #176 are different from the rules in this report. Cf. the failing test cases: https://github.com/bpmn-io/bpmnlint/tree/test-cases-for-180

@barmac barmac reopened this Mar 19, 2025
@barmac barmac added the ready Ready to be worked on label Mar 19, 2025
@Buckwich Buckwich added the in progress Currently worked on label Mar 19, 2025 — with bpmn-io-tasks
@Buckwich Buckwich removed the ready Ready to be worked on label Mar 19, 2025
@Buckwich
Copy link
Member

Buckwich commented Mar 19, 2025 •
edited
Loading

The no-disconnect rules affects Tasks, Subproccesses, Gateways, and Event. Shall I only disable it for tasks or also subprocesses? For Gateways and Events we can keep the rule active.

@barmac
Copy link
Member Author

barmac commented Mar 19, 2025 •
edited
Loading

Let's consider the specification text:

Image

https://www.omg.org/spec/BPMN/2.0/PDF#page=461

Based on this, I think we should exclude only Activities from the no-disconnect rule.

Buckwich added a commit that referenced this issue Mar 19, 2025
@Buckwich
fix: adjust rule no-disconnected to not throw for activities in adh…
072559c 
…oc subprocesses

Closes #180
Buckwich added a commit that referenced this issue Mar 19, 2025
@Buckwich
fix: adjust rule no-implicit-start , no-implicit-start to not thr…
09849aa 
…ow for activities in adhoc subprocesses

Closes #180
@Buckwich Buckwich mentioned this issue Mar 19, 2025
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Mar 19, 2025
Buckwich added a commit that referenced this issue Mar 20, 2025
@Buckwich
fix: skip rules no-disconnect no-implicit-start no-implicit-end…
da68d15 
… within AdHoc SubProcesses

Closes #180
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Buckwich Buckwich

Labels
bug Something isn't working good first issue Good for newcomers rules Concerning existing or missing rules
Projects
None yet
Milestone
No milestone
3 participants
@nikku @Buckwich @barmac