Fix #79 add dropbox-refresh-token

- add `dropboxAppKey`, `dropboxAppSecret` and `dropboxRefreshToken` (long-lived offline refresh token) : required to activate optional dropbox feature.
- MT_DROPBOX_TOKEN is now deprecated
- refacto about Promise

reject

Author: boly38

README.md

@@ -253,10 +253,16 @@ mongoTools.mongorestore({
 ### Dropbox options
 You could create a dropbox app to get a token : cf. https://www.dropbox.com/developers/apps/  "Generated access token"
 
-| option             | env                    |  required | default value   | description                                       |
-|--------------------|------------------------|-----------|-----------------|---------------------------------------------------|
-| `dropboxToken`     | `MT_DROPBOX_TOKEN`     | false     | (none)          | activate dropbox feature if present               |
-| `dropboxLocalPath` | `MT_DROPBOX_LOCAL_PATH` | false     | "dropbox"       | local directory to receive dropbox dump           |
+| option                | env                        |  required | default value   | description                                                          |
+|-----------------------|----------------------------|-----------|-----------------|----------------------------------------------------------------------|
+| `dropboxLocalPath`    | `MT_DROPBOX_LOCAL_PATH`    | false     | "dropbox"       | local directory to receive dropbox dump                              |
+| `dropboxAppKey`       | `MT_DROPBOX_APP_KEY`       | false     | (none)          | (refresh token based) dropbox feature application key. (*1)          |
+| `dropboxAppSecret`    | `MT_DROPBOX_APP_SECRET`    | false     | (none)          | (refresh token based) dropbox feature application secret. (*1)       |
+| `dropboxRefreshToken` | `MT_DROPBOX_REFRESH_TOKEN` | false     | (none)          | (refresh token based) dropbox feature application refreshToken. (*1) |
+| `dropboxToken` (*2)   | `MT_DROPBOX_TOKEN`         | false     | (none)          | DEPRECATED - activate dropbox feature if present. (*2)               |
+
+(*1) `dropboxAppKey`, `dropboxAppSecret` and `dropboxRefreshToken` (long-lived offline refresh token) are required to activate optional dropbox feature. You have some help about how to get them in [dropbox-refresh-token](https://github.com/boly38/dropbox-refresh-token) dedicated helper repository.
+(*2) `dropboxToken` option is DEPRECATED : This was legacy old-long-lived access-token - this kind of token are no more available from dropbox developers portal ([src](https://dropbox.tech/developers/migrating-app-permissions-and-access-tokens)). Please switch to `dropboxAppKey`, `dropboxAppSecret`, and `dropboxRefreshToken` instead. For now this is still supported.
 
 When a token is set, 
 - the `list` feature will list the `/` + `path` dropbox directory

env/initEnv.template.sh

@@ -5,10 +5,17 @@ export MT_MONGO_USER=root
 export MT_MONGO_PWD=mypass
 export MT_MONGO_AUTH_DB=admin
 
-# optional dropbox feature
-# https://www.dropbox.com/developers/apps/
-export MT_DROPBOX_TOKEN=
-
 export MT_PATH=backup
 # MT_SECRET: used to encrypt backup - size 32 - change it
-# export MT_SECRET=12345678901234567890123456789012
+# export MT_SECRET=12345678901234567890123456789012
+
+# TIP: get key,secret from dropbox developers app dev portal : https://www.dropbox.com/developers/apps/
+export MT_DROPBOX_APP_KEY=
+export MT_DROPBOX_APP_SECRET=
+# TIP: long-lived offline refresh-token. cf. https://github.com/boly38/dropbox-refresh-token
+export MT_DROPBOX_REFRESH_TOKEN=
+
+## DEPRECATED SECTION
+# MT_DROPBOX_TOKEN - old-long-lived access-token - no more available from dropbox developers portal
+# export MT_DROPBOX_TOKEN=
+## DEPRECATED SECTION end

eslint.config.js

@@ -2,6 +2,7 @@
 import js from "@eslint/js";
 import globals from "globals";
 import mochaPlugin from 'eslint-plugin-mocha'; // https://www.npmjs.com/package/eslint-plugin-mocha
+import stylisticJs from '@stylistic/eslint-plugin-js'
 export default [
     js.configs.recommended, // Recommended config applied to all files
     mochaPlugin.configs.flat.recommended, // or `mochaPlugin.configs.flat.all` to enable all
@@ -19,8 +20,12 @@ export default [
                 "allowImportExportEverywhere": true
             },
         },
+        plugins: {
+            '@stylistic/js': stylisticJs
+        },
         "rules": {
-            "mocha/no-mocha-arrows": "off"/* pff */
+            "mocha/no-mocha-arrows": "off", /* pff */
+            '@stylistic/js/no-extra-semi': "error", /* to match houndci : https://eslint.org/docs/latest/rules/no-extra-semi */
         }
     }
 ];

lib/MTCommand.js

@@ -65,18 +65,18 @@ class MTCommand {
     if (action === 'list') {
       this.mt.list(new MTOptions()).then((listResult) => {
         console.log(JSON.stringify(listResult, null, 4));
-      }).catch(cmd.logError.bind(cmd));
+      }).catch(error => cmd.logError(error.message));
       return;
     }
     if (action === 'dumpz') {
       this.mt.mongodump(new MTOptions({
             "encrypt":true
       }))
-      .then(cmd.logSuccess.bind(cmd)).catch(cmd.logError.bind(cmd));
+      .then(cmd.logSuccess.bind(cmd)).catch(error => cmd.logError(error.message));
       return;
     }
     if (action === 'dump') {
-      this.mt.mongodump(new MTOptions({})).then(cmd.logSuccess.bind(cmd)).catch(cmd.logError.bind(cmd));
+      this.mt.mongodump(new MTOptions({})).then(cmd.logSuccess.bind(cmd)).catch(error => cmd.logError(error.message));
       return;
     }
     // restore action do need an extra argument: the file to restore
@@ -85,18 +85,17 @@ class MTCommand {
         this.printUsage();
         return;
       }
-      var restoreFile = process.argv.slice(2)[1];
+      const restoreFile = process.argv.slice(2)[1];
       this.mt.mongorestore(new MTOptions({
             dumpFile: restoreFile,
             dropBeforeRestore: false,
             deleteDumpAfterRestore: false
       }))
-      .then(cmd.logSuccess.bind(cmd)).catch(cmd.logError.bind(cmd));
+      .then(cmd.logSuccess.bind(cmd)).catch(error => cmd.logError(error.message));
       return;
     }
     if (action === 'rotation') {
-      this.mt.rotation(new MTOptions()).then(cmd.logSuccess.bind(cmd)).catch(cmd.logError.bind(cmd));
-      return;
+      this.mt.rotation(new MTOptions()).then(cmd.logSuccess.bind(cmd)).catch(error => cmd.logError(error.message));
     }
   }