Skip to content

Commit fd24317

Browse files
committed
[changed] Removed collapsable deprecated functionality.
1 parent efd44d0 commit fd24317

11 files changed

+16
-488
lines changed

Diff for: src/CollapsableMixin.js

-40
This file was deleted.

Diff for: src/CollapsableNav.js

-18
This file was deleted.

Diff for: src/CollapsibleMixin.js

-10
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import React from 'react';
22
import TransitionEvents from './utils/TransitionEvents';
3-
import deprecationWarning from './utils/deprecationWarning';
43

54
const CollapsibleMixin = {
65

@@ -138,15 +137,6 @@ const CollapsibleMixin = {
138137
},
139138

140139
dimension(){
141-
if (typeof this.getCollapsableDimension === 'function') {
142-
deprecationWarning(
143-
'CollapsableMixin.getCollapsableDimension()',
144-
'CollapsibleMixin.getCollapsibleDimension()',
145-
'https://github.com/react-bootstrap/react-bootstrap/issues/425#issuecomment-97110963'
146-
);
147-
return this.getCollapsableDimension();
148-
}
149-
150140
return (typeof this.getCollapsibleDimension === 'function') ?
151141
this.getCollapsibleDimension() :
152142
'height';

Diff for: src/CollapsibleNav.js

+5-14
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,17 @@ import BootstrapMixin from './BootstrapMixin';
33
import CollapsibleMixin from './CollapsibleMixin';
44
import classNames from 'classnames';
55
import domUtils from './utils/domUtils';
6-
import collapsable from './utils/deprecatedProperty';
76

87
import ValidComponentChildren from './utils/ValidComponentChildren';
98
import createChainedFunction from './utils/createChainedFunction';
109

11-
const specCollapsibleNav = {
10+
const CollapsibleNav = React.createClass({
1211
mixins: [BootstrapMixin, CollapsibleMixin],
1312

1413
propTypes: {
1514
onSelect: React.PropTypes.func,
1615
activeHref: React.PropTypes.string,
1716
activeKey: React.PropTypes.any,
18-
collapsable,
1917
collapsible: React.PropTypes.bool,
2018
expanded: React.PropTypes.bool,
2119
eventKey: React.PropTypes.any
@@ -48,16 +46,12 @@ const specCollapsibleNav = {
4846
/*
4947
* this.props.collapsible is set in NavBar when an eventKey is supplied.
5048
*/
51-
const collapsible = this.props.collapsible || this.props.collapsable;
52-
let classes = collapsible ? this.getCollapsibleClassSet('navbar-collapse') : null;
49+
const classes = this.props.collapsible ? this.getCollapsibleClassSet('navbar-collapse') : null;
50+
const renderChildren = this.props.collapsible ? this.renderCollapsibleNavChildren : this.renderChildren;
5351

5452
return (
5553
<div eventKey={this.props.eventKey} className={classNames(this.props.className, classes)} >
56-
{ValidComponentChildren.map(this.props.children,
57-
collapsible ?
58-
this.renderCollapsibleNavChildren :
59-
this.renderChildren
60-
)}
54+
{ValidComponentChildren.map(this.props.children, renderChildren)}
6155
</div>
6256
);
6357
},
@@ -109,9 +103,6 @@ const specCollapsibleNav = {
109103
}
110104
);
111105
}
112-
};
113-
114-
const CollapsibleNav = React.createClass(specCollapsibleNav);
115-
CollapsibleNav._spec = specCollapsibleNav;
106+
});
116107

117108
export default CollapsibleNav;

Diff for: src/Nav.js

+3-8
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import BootstrapMixin from './BootstrapMixin';
33
import CollapsibleMixin from './CollapsibleMixin';
44
import classNames from 'classnames';
55
import domUtils from './utils/domUtils';
6-
import collapsable from './utils/deprecatedProperty';
76

87
import ValidComponentChildren from './utils/ValidComponentChildren';
98
import createChainedFunction from './utils/createChainedFunction';
@@ -18,7 +17,6 @@ const Nav = React.createClass({
1817
stacked: React.PropTypes.bool,
1918
justified: React.PropTypes.bool,
2019
onSelect: React.PropTypes.func,
21-
collapsable,
2220
collapsible: React.PropTypes.bool,
2321
expanded: React.PropTypes.bool,
2422
navbar: React.PropTypes.bool,
@@ -46,12 +44,9 @@ const Nav = React.createClass({
4644
},
4745

4846
render() {
49-
const collapsible = this.props.collapsible || this.props.collapsable;
50-
let classes = collapsible ? this.getCollapsibleClassSet() : {};
47+
const classes = this.props.collapsible ? this.getCollapsibleClassSet('navbar-collapse') : null;
5148

52-
classes['navbar-collapse'] = collapsible;
53-
54-
if (this.props.navbar && !collapsible) {
49+
if (this.props.navbar && !this.props.collapsible) {
5550
return (this.renderUl());
5651
}
5752

@@ -63,7 +58,7 @@ const Nav = React.createClass({
6358
},
6459

6560
renderUl() {
66-
let classes = this.getBsClassSet();
61+
const classes = this.getBsClassSet();
6762

6863
classes['nav-stacked'] = this.props.stacked;
6964
classes['nav-justified'] = this.props.justified;

Diff for: src/Panel.js

+8-14
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@ import classNames from 'classnames';
33

44
import BootstrapMixin from './BootstrapMixin';
55
import CollapsibleMixin from './CollapsibleMixin';
6-
import collapsable from './utils/deprecatedProperty';
76

87
const Panel = React.createClass({
98
mixins: [BootstrapMixin, CollapsibleMixin],
109

1110
propTypes: {
12-
collapsable,
1311
collapsible: React.PropTypes.bool,
1412
onSelect: React.PropTypes.func,
1513
header: React.PropTypes.node,
@@ -56,21 +54,18 @@ const Panel = React.createClass({
5654
},
5755

5856
render() {
59-
let classes = this.getBsClassSet();
60-
const collapsible = this.props.collapsible || this.props.collapsable;
61-
6257
return (
6358
<div {...this.props}
64-
className={classNames(this.props.className, classes)}
65-
id={collapsible ? null : this.props.id} onSelect={null}>
59+
className={classNames(this.props.className, this.getBsClassSet())}
60+
id={this.props.collapsible ? null : this.props.id} onSelect={null}>
6661
{this.renderHeading()}
67-
{collapsible ? this.renderCollapsableBody() : this.renderBody()}
62+
{this.props.collapsible ? this.renderCollapsibleBody() : this.renderBody()}
6863
{this.renderFooter()}
6964
</div>
7065
);
7166
},
7267

73-
renderCollapsableBody() {
68+
renderCollapsibleBody() {
7469
let collapseClass = this.prefixClass('collapse');
7570

7671
return (
@@ -147,21 +142,20 @@ const Panel = React.createClass({
147142

148143
renderHeading() {
149144
let header = this.props.header;
150-
const collapsible = this.props.collapsible || this.props.collapsable;
151145

152146
if (!header) {
153147
return null;
154148
}
155149

156150
if (!React.isValidElement(header) || Array.isArray(header)) {
157-
header = collapsible ?
158-
this.renderCollapsableTitle(header) : header;
151+
header = this.props.collapsible ?
152+
this.renderCollapsibleTitle(header) : header;
159153
} else {
160154
const className = classNames(
161155
this.prefixClass('title'), header.props.className
162156
);
163157

164-
if (collapsible) {
158+
if (this.props.collapsible) {
165159
header = cloneElement(header, {
166160
className,
167161
children: this.renderAnchor(header.props.children)
@@ -190,7 +184,7 @@ const Panel = React.createClass({
190184
);
191185
},
192186

193-
renderCollapsableTitle(header) {
187+
renderCollapsibleTitle(header) {
194188
return (
195189
<h4 className={this.prefixClass('title')}>
196190
{this.renderAnchor(header)}

Diff for: src/index.js

-4
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ import Button from './Button';
88
import ButtonGroup from './ButtonGroup';
99
import ButtonInput from './ButtonInput';
1010
import ButtonToolbar from './ButtonToolbar';
11-
import CollapsableNav from './CollapsableNav';
1211
import CollapsibleNav from './CollapsibleNav';
1312
import Carousel from './Carousel';
1413
import CarouselItem from './CarouselItem';
1514
import Col from './Col';
16-
import CollapsableMixin from './CollapsableMixin';
1715
import CollapsibleMixin from './CollapsibleMixin';
1816
import DropdownButton from './DropdownButton';
1917
import DropdownMenu from './DropdownMenu';
@@ -64,12 +62,10 @@ export default {
6462
ButtonGroup,
6563
ButtonInput,
6664
ButtonToolbar,
67-
CollapsableNav,
6865
CollapsibleNav,
6966
Carousel,
7067
CarouselItem,
7168
Col,
72-
CollapsableMixin,
7369
CollapsibleMixin,
7470
DropdownButton,
7571
DropdownMenu,

Diff for: src/utils/deprecatedProperty.js

-13
This file was deleted.

0 commit comments

Comments
 (0)