-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert does not play well with CRAN #5
Comments
yes, I should also use the latest release and fix all these r cmd check notes at cran: https://cran.r-project.org/web/checks/check_results_dlib.html |
I am sorry. I don’t think I have the right skills to help you on this. I do not really know how to fix this problem. I just noticed that it doesn’t pass CRAN checks. |
dlib uses assert statements all over the place - will indeed not be trivial to replace these |
Let's forget about my package for now (there is indeed an item in my todo list to set up continuous integration but there are more important things to fix first as this is originally a package written by many other colleagues). For dlib to be used by other packages, the assert statement needs to be replaced by something Rcpp equivalent, otherwise CRAN will complain. But we could use the same trick you used for cout for instance, i.e. redirecting |
Yes, sure - a pull request would be great. Code is at https://github.com/bnosac/dlib/blob/master/src/r_cmd_check_happiness.cc and https://github.com/bnosac/dlib/blob/master/src/r_cmd_check_happiness.h |
It seems that conversions of
exit()
,abort()
,std::cout
andstd::cerr
into Rcpp equivalents have been done for complying to CRAN rules. But I just ran into this error again when CRAN-checking one of my packages the links to dlib. It seemsassert()
is prohibited as well by CRAN but it is still in use in dlib as far as I understand.The text was updated successfully, but these errors were encountered: