Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Extract subprocess calls into a function #3194

Open
joaoantoniocardoso opened this issue Mar 10, 2025 · 0 comments
Open

[core] Extract subprocess calls into a function #3194

joaoantoniocardoso opened this issue Mar 10, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@joaoantoniocardoso
Copy link
Member

joaoantoniocardoso commented Mar 10, 2025

Since we are using more and more of this, with slightly different parameters, we would benefit from having it extracted into an ergonomic function to guarantee a coherent code to these critical parts of the system logic.

I think we can extract this into a function and share this code with core/services/autopilot_manager/mavlink_proxy/AbstractRouter.py:AbstractRouter::start and core/services/helper/main.py:ping.

Originally posted by @joaoantoniocardoso in #3154 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant