Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node <12, ESM-only, tooling updates #41

Closed
wants to merge 5 commits into from

Conversation

tchetwin
Copy link
Collaborator

@tchetwin tchetwin commented Jun 1, 2021

Fixes #32

https://node.green indicates that we can use #private instance fields with the required node >= 12.20 engine.

typedoc@beta is required in conjunction with [email protected]

@tchetwin tchetwin changed the base branch from v2 to master June 1, 2021 22:09
@tchetwin tchetwin closed this Jun 1, 2021
@tchetwin tchetwin reopened this Jun 1, 2021
@tchetwin tchetwin force-pushed the pasta-esm branch 3 times, most recently from f7cd6d2 to aea1caa Compare June 6, 2021 08:34
@tchetwin tchetwin marked this pull request as ready for review June 6, 2021 08:37
ldarbi
ldarbi previously approved these changes Jun 9, 2021
Copy link
Collaborator

@ldarbi ldarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ldarbi
ldarbi previously approved these changes Jun 9, 2021
tchetwin added 5 commits June 29, 2021 08:56
- Only export ./src/main.ts
- Transpile to ESM, not CJS
- tape -> mocha for testing

Signed-off-by: Thomas Chetwin <[email protected]>
- bump ESLint (and plugin) versions
- bump Prettier 1 -> 2

Signed-off-by: Thomas Chetwin <[email protected]>
Signed-off-by: Thomas Chetwin <[email protected]>
- latest typedoc
- drop typedoc-plugin-sourcefile-url
- explicitly specify entrypoints

Signed-off-by: Thomas Chetwin <[email protected]>
@tchetwin
Copy link
Collaborator Author

Rebased to include recent GitHub Actions swap

@tchetwin tchetwin closed this Aug 31, 2023
@tchetwin
Copy link
Collaborator Author

Will address in multiple PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Changes Queue
2 participants