Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Zoom In and Zoom Out on file viewer #33

Open
sondreb opened this issue Aug 6, 2024 · 2 comments
Open

Implement Zoom In and Zoom Out on file viewer #33

sondreb opened this issue Aug 6, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@sondreb
Copy link
Member

sondreb commented Aug 6, 2024

Currently the Zoom buttons on File Viewer are disabled. This is a nice isolated task for someone to complete.
@sondreb sondreb added the good first issue Good for newcomers label Aug 6, 2024
@cpwallah
Copy link
Contributor

cpwallah commented Aug 8, 2024

made a pr @sondreb

@sondreb
Copy link
Member Author

sondreb commented Sep 24, 2024

The PR has been merge which has partially implemented the zoom. More work is needed, as the current implementation simply zooms the iframe.

For images, it must zoom them more properly, see issue in this screenshot:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sondreb @cpwallah