ci: Clean up workflows

Author: bjw-s

.github/workflows/docs-publish.yaml

@@ -19,23 +19,13 @@ jobs:
     name: Flux Local Test
     runs-on: ubuntu-latest
     steps:
-      - name: Generate Token
-        uses: actions/create-github-app-token@v1
-        if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
-        id: app-token
-        with:
-          app-id: ${{ secrets.LAB_ASSISTANT_APP_ID }}
-          private-key: ${{ secrets.LAB_ASSISTANT_APP_KEY }}
-
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          token: "${{ steps.app-token.outputs.token }}"
 
       - name: Run flux-local test
         uses: docker://ghcr.io/allenporter/flux-local:v7.2.0
         with:
-          args: test --enable-helm --path /github/workspace/kubernetes/flux/cluster
+          args: test --enable-helm --all-namespaces --path /github/workspace/kubernetes/flux/cluster -v
 
   diff:
     name: Flux Local Diff
@@ -50,24 +40,14 @@ jobs:
       max-parallel: 4
       fail-fast: false
     steps:
-      - name: Generate Token
-        uses: actions/create-github-app-token@v1
-        if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
-        id: app-token
-        with:
-          app-id: ${{ secrets.LAB_ASSISTANT_APP_ID }}
-          private-key: ${{ secrets.LAB_ASSISTANT_APP_KEY }}
-
       - name: Checkout Pull Request Branch
         uses: actions/checkout@v4
         with:
-          token: "${{ steps.app-token.outputs.token }}"
           path: pull
 
       - name: Checkout Default Branch
         uses: actions/checkout@v4
         with:
-          token: "${{ steps.app-token.outputs.token }}"
           ref: "${{ github.event.repository.default_branch }}"
           path: default
 
@@ -88,29 +68,37 @@ jobs:
       - name: Generate Diff
         id: diff
         run: |
-          cat diff.patch;
           {
               echo 'diff<<EOF'
               cat diff.patch
               echo EOF
-          } >> "$GITHUB_OUTPUT";
+          } >> "${GITHUB_OUTPUT}";
           {
-              echo "### Diff"
+              echo "## Flux ${{ matrix.resources }} diff"
               echo '```diff'
               cat diff.patch
               echo '```'
-          } >> "$GITHUB_STEP_SUMMARY"
+          } >> "${GITHUB_STEP_SUMMARY}"
+
+      - name: Generate Token
+        uses: actions/create-github-app-token@v1
+        if: ${{ github.event.pull_request.head.repo.full_name == github.repository && steps.diff.outputs.diff != '' }}
+        id: app-token
+        with:
+          app-id: ${{ secrets.LAB_ASSISTANT_APP_ID }}
+          private-key: ${{ secrets.LAB_ASSISTANT_APP_KEY }}
 
       - if: ${{ steps.diff.outputs.diff != '' }}
         name: Add comment
         uses: mshick/add-pr-comment@v2
         with:
           repo-token: "${{ steps.app-token.outputs.token }}"
-          message-id: "${{ github.event.pull_request.number }}/main/${{ matrix.resources }}"
+          message-id: "${{ github.event.pull_request.number }}/kubernetes/${{ matrix.resources }}"
           message-failure: Diff was not successful
           message: |
             ```diff
             ${{ steps.diff.outputs.diff }}
+            ```
 
   flux-local-success:
     needs:

.github/workflows/flux-local.yaml

@@ -19,8 +19,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Get changed files
         id: changed-files
@@ -43,8 +41,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Get changed files
         id: changed-files
@@ -72,8 +68,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Get changed files
         id: changed-files
@@ -95,8 +89,6 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
 
       - name: Get changed files
         id: changed-files

.github/workflows/lint.yaml

@@ -30,7 +30,6 @@ jobs:
     outputs:
       default: ${{ steps.extract-images.outputs.default }}
       pull: ${{ steps.extract-images.outputs.pull }}
-      matrix: ""
     steps:
       - name: Generate Token
         uses: actions/create-github-app-token@v1
@@ -54,18 +53,17 @@ jobs:
             --all-namespaces
             --path /github/workspace/kubernetes/flux/cluster
             --enable-images
-            --output yaml
-            --output-file images.yaml
+            --only-images
+            --output json
+            --output-file images.json
 
       - name: Extract Images
         id: extract-images
         run: |
-          images=$(yq --indent=0 --output-format=json \
-              '[.. | .images? | select(. != null)] | flatten | sort | unique' images.yaml \
-          )
-          echo "${{ matrix.branches }}=${images}" >> "$GITHUB_OUTPUT"
+          echo "${{ matrix.branches }}=$(jq --compact-output '.' images.json)" >> "${GITHUB_OUTPUT}"
 
   compare-images:
+    if: ${{ needs.extract-images.outputs.default != needs.extract-images.outputs.pull }}
     name: Compare Images
     runs-on: ubuntu-latest
     needs:
@@ -83,6 +81,13 @@ jobs:
           )
           echo "images=${images}" >> "${GITHUB_OUTPUT}"
 
+          {
+              echo "## New images to Pull"
+              echo '```json'
+              echo "${images}" | jq
+              echo '```'
+          } >> "${GITHUB_STEP_SUMMARY}"
+
   pre-pull-images:
     if: ${{ needs.compare-images.outputs.images != '[]' }}
     name: Pre-pull Images