Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Table scheme configuration removal/refactor #115

Open
bivashy opened this issue Nov 9, 2023 · 0 comments
Open

[Feature] Table scheme configuration removal/refactor #115

bivashy opened this issue Nov 9, 2023 · 0 comments
Labels
type: enhancement New feature or request

Comments

@bivashy
Copy link
Owner

bivashy commented Nov 9, 2023

Is your feature request related to a problem? Please describe.
This feature is broken with migration, and makes code maintaining harder:

  1. https://github.com/bivashy/MC-Auth-with-Link/blob/main/core/src/main/java/me/mastercapexd/auth/database/dao/AuthAccountDao.java#L49-L97
  2. https://github.com/bivashy/MC-Auth-with-Link/blob/main/core/src/main/java/me/mastercapexd/auth/database/dao/AccountLinkDao.java#L42-L67

Describe the solution you'd like
Two ways to resolve this problem:

  • Removal: Completely remove this feature, because not many people uses it.
  • Refactor: Create AccountLinkTableConfig, AuthAccountTableConfig and place them into their 'dao' classes, which should improve code readability. Perhaps moving schema configuration into other .yml file too.
    Currently I don't know which way is better to choose
@bivashy bivashy added the type: enhancement New feature or request label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bivashy