Fixed phpstan and psalm errors

Author: divineniiquaye

Diff for: phpstan.neon.dist

@@ -9,7 +9,7 @@ parameters:
     treatPhpDocTypesAsCertain: false
 
     ignoreErrors:
-        - "#^Construct empty\\(\\) is not allowed. Use more strict comparison.$#"
+        - "#^Construct empty\\(\\) is not allowed. Use more strict comparison|Call to an undefined method ReflectionMethod|ReflectionProperty\\:\\:getAttributes\\(\\).$#"
         - "#^Property Rade\\\\DI\\\\Loader\\\\FileLoader|ClosureLoader\\:\\:\\$container \\(Rade\\\\DI\\\\Container\\|Rade\\\\DI\\\\ContainerBuilder\\) does not accept Rade\\\\DI\\\\AbstractContainer.$#"
         -
             message: "#^Parameter \\#2 \\$service \\(Rade\\\\DI\\\\Definition\\|Rade\\\\DI\\\\RawDefinition\\) of method Rade\\\\DI\\\\ContainerBuilder\\:\\:doCreate\\(\\) should be contravariant with parameter \\$service \\(callable\\(\\): mixed\\) of method Rade\\\\DI\\\\AbstractContainer\\:\\:doCreate\\(\\)$#"

Diff for: psalm.xml.dist

@@ -39,5 +39,26 @@
                 <referencedClass name="Psr\Container\ContainerExceptionInterface"/>
             </errorLevel>
         </InvalidCatch>
+
+        <UndefinedMethod>
+            <errorLevel type="suppress">
+                <referencedMethod name="Rade\DI\Services\ServiceProviderInterface::getid"/>
+                <file name="src/Loader/YamlFileLoader.php"/>
+            </errorLevel>
+        </UndefinedMethod>
+
+        <PropertyNotSetInConstructor>
+            <errorLevel type="suppress">
+                <file name="src/Builder/CodePrinter.php"/>
+                <file name="src/Definition.php"/>
+                <referencedProperty name="Rade\DI\Loader\YamlFileLoader::$yamlParser" />
+            </errorLevel>
+        </PropertyNotSetInConstructor>
+
+        <PossiblyUndefinedStringArrayOffset>
+            <errorLevel type="suppress">
+                <file name="src/ContainerBuilder.php"/>
+            </errorLevel>
+        </PossiblyUndefinedStringArrayOffset>
     </issueHandlers>
 </psalm>

Diff for: src/Loader/YamlFileLoader.php

@@ -78,8 +78,7 @@ class YamlFileLoader extends FileLoader
         'calls' => 'bind',
     ];
 
-    /** @var YamlParser */
-    private $yamlParser;
+    private ?YamlParser $yamlParser = null;
 
     /**
      * {@inheritdoc}
@@ -118,13 +117,11 @@ public function supports($resource, string $type = null)
     /**
      * Loads a YAML file.
      *
-     * @param string $file
-     *
      * @throws \InvalidArgumentException when the given file is not a local file or when it does not exist
      *
-     * @return array The file content
+     * @return array<int|string,mixed> The file content
      */
-    protected function loadFile($file)
+    protected function loadFile(string $file): array
     {
         if (!\class_exists(\Symfony\Component\Yaml\Parser::class)) {
             throw new \RuntimeException('Unable to load YAML config files as the Symfony Yaml Component is not installed.');
@@ -155,6 +152,9 @@ protected function loadFile($file)
         return $configuration;
     }
 
+    /**
+     * @param array<string,mixed> $content
+     */
     private function parseImports(array $content, string $file): void
     {
         if (!isset($content['imports'])) {
@@ -194,7 +194,10 @@ private function parseImports(array $content, string $file): void
         unset($content['imports']);
     }
 
-    private function loadContent($content, $path): void
+    /**
+     * @param array<string,mixed> $content
+     */
+    private function loadContent(array $content, string $path): void
     {
         // imports
         $this->parseImports($content, $path);
@@ -223,6 +226,8 @@ private function loadContent($content, $path): void
 
     /**
      * Loads Service Providers.
+     *
+     * @param array<string,mixed> $content
      */
     private function loadServiceProviders(array $content, string $path): void
     {
@@ -261,6 +266,8 @@ private function loadServiceProviders(array $content, string $path): void
     /**
      * Resolves services.
      *
+     * @param TaggedValue|array|string|null $value
+     *
      * @return array|string|Reference|Statement|object|null
      */
     private function resolveServices($value, string $file, bool $isParameter = false)
@@ -352,6 +359,9 @@ private function resolveServices($value, string $file, bool $isParameter = false
         return $this->resolveParameters($value);
     }
 
+    /**
+     * @param array<string,mixed> $content
+     */
     private function parseDefinitions(array $content, string $file): void
     {
         if (!isset($content['services'])) {
@@ -460,6 +470,9 @@ private function parseDefaults(array &$content, string $file): array
     /**
      * Parses a definition.
      *
+     * @param array<string,mixed> $service
+     * @param array<string,mixed> $defaults
+     *
      * @throws \InvalidArgumentException
      */
     private function parseDefinition(string $id, array $service, string $file, array $defaults, Definition $definition = null): void
@@ -561,7 +574,7 @@ private function parseDefinition(string $id, array $service, string $file, array
     /**
      * @param array<int,string[]> $bindings
      *
-     * @return array<int,string[]>
+     * @return array<int,mixed>
      */
     private function parseDefinitionBinds(string $id, array $bindings, string $file, Definition $definition = null): array
     {
@@ -604,6 +617,11 @@ private function parseDefinitionBinds(string $id, array $bindings, string $file,
         return $bindings;
     }
 
+    /**
+     * @param array<int|string,mixed> $tags
+     *
+     * @return mixed[]
+     */
     private function parseDefinitionTags(string $id, array $tags, string $file): array
     {
         if ('in "_defaults"' !== $id) {
@@ -637,6 +655,8 @@ private function parseDefinitionTags(string $id, array $tags, string $file): arr
 
     /**
      * Checks the keywords used to define a service.
+     *
+     * @param array<string,mixed> $definition
      */
     private function checkDefinition(string $id, array $definition, string $file): void
     {