You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GetVirtualTransactionSize fails to account for sigops if passed the transaction alone.
This could confuse a user into thinking the transaction they were sent, still unconfirmed, has a reasonable fee rate, when it might very well not due to a bunch of sigops in another output or input.
Annoyingly, GetTransactionSigOpCost looks liable to assert if used on a confirmed transaction. It wouldn't make sense to stop reporting the correct virtual size after a transaction confirms, so this looks like a pain to fix.
The text was updated successfully, but these errors were encountered:
GetVirtualTransactionSize
fails to account for sigops if passed the transaction alone.This could confuse a user into thinking the transaction they were sent, still unconfirmed, has a reasonable fee rate, when it might very well not due to a bunch of sigops in another output or input.
Annoyingly,
GetTransactionSigOpCost
looks liable to assert if used on a confirmed transaction. It wouldn't make sense to stop reporting the correct virtual size after a transaction confirms, so this looks like a pain to fix.The text was updated successfully, but these errors were encountered: