Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ellipsify the version number on the about screen #381

Open
1 task done
GBKS opened this issue Dec 7, 2023 · 3 comments
Open
1 task done

Ellipsify the version number on the about screen #381

GBKS opened this issue Dec 7, 2023 · 3 comments

Comments

@GBKS
Copy link
Contributor

GBKS commented Dec 7, 2023

Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

  • I still think this issue should be opened here

Report

The version number overlaps with the label. On tablet, the row item expands beyond its container boundaries on the right. See screenshots.

image

We could ellipse this number. If it is important to show the whole thing, maybe consider using a vertical layout (value text below the label text).

Since this links to a website, the icon should also be the link icon used for the website and source code links further up on the screen.

I am also curious as to what version this refers to. Aren't version usually just regular numbers, like Bitcoin Core 26?

@pablomartin4btc
Copy link
Contributor

@GBKS is this still an issue? (on mobile/ tablet)

I see it correctly in the desktop version at the moment:

image

@jarolrod
Copy link
Member

I don't believe this is an issue anymore with updates that were done to all the elements here.

@GBKS the version you're seeing there contains what top commit the version of the GUI you're using was built with. This has always been done for user-done builds in the case that an issue arises, this commit hash shows where the user built at. Proper releases only have the Core version number without the commit hash (v28.0)

@GBKS
Copy link
Contributor Author

GBKS commented Sep 26, 2024

Is it resolved by just having shorter strings or by automatically eliding ("...") text (which is the more robust solution)? Seems like QML supports this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants