Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): workspace watcher #5200

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arendjr
Copy link
Contributor

@arendjr arendjr commented Feb 25, 2025

Summary

🎉

(it keeps the workspace in the daemon in sync with the FS)

Test Plan

Test added.

@github-actions github-actions bot added A-CLI Area: CLI A-Core Area: core A-Project Area: project A-LSP Area: language server protocol labels Feb 25, 2025
@arendjr arendjr marked this pull request as draft February 25, 2025 15:50
Copy link

codspeed-hq bot commented Feb 25, 2025

CodSpeed Performance Report

Merging #5200 will not alter performance

Comparing arendjr:workspace-watcher (e705705) with main (43601b2)

Summary

✅ 97 untouched benchmarks

@@ -204,3 +193,23 @@ impl Projects {
!is_feature_included
}
}

#[derive(Clone, Copy, Debug, Deserialize, Eq, Hash, PartialEq, Serialize)]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this block because it was annoying that the definition was in the middle between the Projects definition and its implementation.

@arendjr arendjr marked this pull request as ready for review February 26, 2025 15:53
@arendjr arendjr requested review from a team February 26, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Core Area: core A-LSP Area: language server protocol A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant