fix(parser): gracefully handle stalled parser in object patterns #5198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4622.
In some cases,
)
and]
could cause the parser to stall inside object patterns, triggering an internal assertion.I was initially able to create a very specific fix by checking for these two characters, but it also created some fallout in other snapshots. Those snapshots were also for error cases, so it wasn't a dealbreaker, but the fix itself also felt brittle: what if another character or combination could trigger a stalled parser too?
So instead I changed how
ParserProgress
works, allowing us to gracefully handle stalled parsers. This way we don't fail with an assertion, but we can provide a nice diagnostic.Test Plan
Test case added.