ci: move test-node-api job to a new pull_request_node.yml workflow
#5192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #5190 (comment)
Testing Node.js API should be triggered on either Rust files or JS/TS files are changed. I added a new workflow
pull_request_node.ymland moved the job.Plus, I added
package.jsonandpnpm-lock.yamlfiles to the trigger ofpull_request_js.ymlso any package updates will trigger the workflow.Test Plan
Unfortunately this PR doesn't have any changes to trigger the workflow, but we can check in #5190 after merged this. At least existing CIs shouldn't be an error on the analysing phase.