Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As I'm preparing to implement a Workspace watcher, I noticed a few minor code cleanups I wanted to do. I initially hit a bit of a dead end with my watcher approach, but I think the cleanups still make sense to merge to prevent a large PR down the line. Specifically:
init_thread_pool()
function, since it doesn't really seem to belong inside the scanner.scan()
to be a method onWorkspaceServer
instead of a standalone function. Not really important, but seeing how the first method was a reference to theWorkspaceServer
anyway, this seems cleaner. (I was going to do the same for the watcher, but that didn't work out.)tests/workspace.rs
tosrc/workspace.tests.rs
. This has the advantage that we can move an inline test that is insrc/workspace.rs
there as well, and we only need to keep onesnapshots
folder instead of two. It also saves a lot of indentation in the file.static_assertions
to the top-levelCargo.toml
.Test Plan
CI should remain green.