Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade pnpm to v10 #5190

Merged
merged 1 commit into from
Feb 24, 2025
Merged

build: upgrade pnpm to v10 #5190

merged 1 commit into from
Feb 24, 2025

Conversation

siketyan
Copy link
Member

Summary

This pull request upgrades pnpm to v10 (latest).
I don't know why this is not yet achieved by Renovate.

Test Plan

Existing CIs for Node.js should pass.

@siketyan siketyan self-assigned this Feb 24, 2025
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it does appear changes to the package.json don't trigger the right CI jobs, so that might be something we want to look into.

@ematipico
Copy link
Member

I don't know why this is not yet achieved by Renovate.

I believe we disallow major upgrades, but I might be wrong

@siketyan
Copy link
Member Author

@arendjr
We have two workflows triggered by pull_request trigger:

  • pull_request.yml: When Rust or Cargo files changed
  • pull_request_js.yml: When JS/TS files changed

Currently we run Node.js API tests in pull_request.yml, so this PR doesn't trigger it. However I think we should run tests for Node.js APIs when either Rust files or JS/TS files are changed. Maybe we should introduce a new workflow pull_request_node.yml or something to trigger by both files?

@siketyan
Copy link
Member Author

@ematipico
I don't see any configuration that disables major upgrades: https://github.com/biomejs/biome/blob/d40bf1f63715156dcfd727bfb4a71e56eb934c40/.github/renovate.json

I checked https://developer.mend.io/github/biomejs/biome and pnpm is on the list, but there is a long awaiting queue 😓

@arendjr
Copy link
Contributor

arendjr commented Feb 24, 2025

I think we should run tests for Node.js APIs when either Rust files or JS/TS files are changed. Maybe we should introduce a new workflow pull_request_node.yml or something to trigger by both files?

This makes sense to me, yes.

But I meant that it seems a mistake that pull_request_js.yml isn't triggered when package.json changes, as in this PR.

@siketyan
Copy link
Member Author

But I meant that it seems a mistake that pull_request_js.yml isn't triggered when package.json changes, as in this PR.

Yeah, that is also a problem. I will create a new PR to resolve these before merging this one.

@siketyan siketyan force-pushed the build/pnpm-10 branch 2 times, most recently from 29015e3 to 1bea0b8 Compare February 24, 2025 09:28
@siketyan siketyan merged commit 06d15f3 into main Feb 24, 2025
4 checks passed
@siketyan siketyan deleted the build/pnpm-10 branch February 24, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants