fix(html): fix html configuration having no effect #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
dyc3
force-pushed
the
html-options-plumbing
branch
from
e8e0429 to
193985e
Compare
dyc3
force-pushed
the
html-options-plumbing
branch
from
193985e to
55a70be
Compare
CodSpeed Performance ReportMerging #5149 will not alter performanceComparing Summary
|
ah-yu
approved these changes
Feb 18, 2025
arendjr
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I could have sworn I already fixed this, but html configuration wasn't making it all the way down into the formatter's options.
Test Plan
Added a new snapshot test that changes one of the affected options, and shows that they get used.