-
-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(linter): severity and recommendation of lint rules #5133
Conversation
670550d
to
627948f
Compare
CodSpeed Performance ReportMerging #5133 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
.changeset/spotty-buckets-hang.md
Outdated
The following rules aren't recommended anymore: | ||
- `noDelete` | ||
- `noForEach` | ||
- `noFlatMapIdentity` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this rule is no longer recommended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy has this rule under the pedantic category, and it doesn't recommended it, I think we should follow their lead and stick with it.
Our recommendation set is very opinionated and we should reduce it. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many users like the fact that Biome is opinionated.
I accept that we could be more cautious about what we add in the recommended rule set.
Personally I could keep this rule in the recommended set because it brings one of the mission of Biome: making dev better dev by helping to learn JS API.
We could reduce the severity level to information
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Summary
noForEach
isn't recommended anymore because performance is debatable (it depends by the runtime) and it changes with time;*useless*
rules emit an information diagnostic, because they trigger ... unless code! no need to block the CI for it;noDelete
isn't recommended anymore because it's the way to for environment variables in Node.js, so Biome should be less pedantic about it;Test Plan
Many snapshot tests are updated because our test infra was hardcoding the severity of our rules. Now that rules have their own severity, there's no need for that anymore.