Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix CLI flag of bracketSpacing option for lang-specific override #5130

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

siketyan
Copy link
Member

Summary

This pull request fixes a CLI flag --bracket-spacing is duplicated between the global configuration and the lang-specific override for JavaScript.

Test Plan

Snapshot changed, existing tests should pass.

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project labels Feb 16, 2025
@siketyan siketyan changed the title fix(cli): Fix CLI flag of bracketSpacing option for lang-specific override fix(cli): fix CLI flag of bracketSpacing option for lang-specific override Feb 16, 2025
Copy link
Contributor

@arendjr arendjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just added a bit of rewording for the changeset.

@siketyan siketyan force-pushed the fix/cli-option-override branch from 1651709 to cb4258c Compare February 16, 2025 08:25
@arendjr arendjr merged commit 0cbbbe6 into biomejs:main Feb 16, 2025
11 checks passed
@siketyan siketyan deleted the fix/cli-option-override branch February 16, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI A-Project Area: project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants