Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(format/html): fix extra characters getting added in attribute quotes #5128

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

dyc3
Copy link
Contributor

@dyc3 dyc3 commented Feb 15, 2025

Summary

I accidentally used the wrong range values for these, and that caused the ranges to end up larger than they should have.

Fixes #4926

Test Plan

Snapshots have been updated.

@github-actions github-actions bot added A-Formatter Area: formatter L-HTML Language: HTML labels Feb 15, 2025
Copy link

codspeed-hq bot commented Feb 15, 2025

CodSpeed Performance Report

Merging #5128 will improve performances by 6.89%

Comparing html-fix-string-ranges (a4c79d5) with main (08b7987)

Summary

⚡ 1 improvements
✅ 93 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
react.production.min_3378072959512366797.js[cached] 2 ms 1.9 ms +6.89%

@dyc3 dyc3 requested review from a team February 15, 2025 20:38
@dyc3 dyc3 merged commit 1949e57 into main Feb 16, 2025
13 checks passed
@dyc3 dyc3 deleted the html-fix-string-ranges branch February 16, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Formatter Area: formatter L-HTML Language: HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝 HTML Formatter Bug: Extra spaces inserted in quoted attributes
3 participants