feat(linter): update useImportExtensions to suggest actual extensions #5332
+1,011
−967
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5328.
useImportExtensions
has been updated to suggest actual file extensions instead of guesses based on hueristics. This is based on the dependency graph.As part of this, the
suggestedExtensions
option has been removed. A simpler, new option calledforceJsExtensions
has been introduced for those who usetsc
's"module": "node16"
setting.The rule also no longer reports diagnostics to add an extension when the path doesn't exist at all, with or without extension.
cc @drdaemos
Test Plan
Tests updated.