Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement allowedLabels option for noConfusingLabels #5188

Open
arendjr opened this issue Feb 24, 2025 · 1 comment
Open

Implement allowedLabels option for noConfusingLabels #5188

arendjr opened this issue Feb 24, 2025 · 1 comment
Assignees
Labels
A-Linter Area: linter S-Help-wanted Status: you're familiar with the code base and want to help the project

Comments

@arendjr
Copy link
Contributor

arendjr commented Feb 24, 2025

Discussed in #5179

The lint rule lint/suspicious/noConfusingLabels can currently only be enabled or disabled (or set to a specific level). I think the rule should get some options where you can specify a list of allowed labels. This would be in addition to labels for loops which are already allowed.

{
  "linter": {
    "rules": {
      "lint/suspicious/noConfusingLabels": {
        "level": "warn",
        "allowedLabels": ["DEV"]
      }
    }
  }
}
@arendjr arendjr added A-Linter Area: linter S-Help-wanted Status: you're familiar with the code base and want to help the project labels Feb 24, 2025
@tim-we
Copy link

tim-we commented Feb 24, 2025

Thanks @arendjr for creating this issue. I'm happy to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter S-Help-wanted Status: you're familiar with the code base and want to help the project
Projects
None yet
Development

No branches or pull requests

2 participants